From: Nam Cao <namcao@linutronix.de>
To: Xi Ruoyao <xry111@xry111.site>
Cc: Christian Brauner <brauner@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Valentin Schneider <vschneid@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
John Ogness <john.ogness@linutronix.de>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rt-devel@lists.linux.dev, linux-rt-users@vger.kernel.org,
Joe Damato <jdamato@fastly.com>,
Martin Karsten <mkarsten@uwaterloo.ca>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v3] eventpoll: Fix priority inversion problem
Date: Fri, 11 Jul 2025 07:02:17 +0200 [thread overview]
Message-ID: <20250711050217.OMtx7Cz6@linutronix.de> (raw)
In-Reply-To: <c720efb6a806e0ffa48e35d016e513943d15e7c0.camel@xry111.site>
On Thu, Jul 10, 2025 at 05:47:57PM +0800, Xi Ruoyao wrote:
> It didn't work :(.
Argh :(
Another possibility is that you are running into event starvation problem.
Can you give the below patch a try? It is not the real fix, the patch hurts
performance badly. But if starvation is really your problem, it should
ameliorate the situation:
diff --git a/fs/eventpoll.c b/fs/eventpoll.c
index 895256cd2786..0dcf8e18de0d 100644
--- a/fs/eventpoll.c
+++ b/fs/eventpoll.c
@@ -1764,6 +1764,8 @@ static int ep_send_events(struct eventpoll *ep,
__llist_add(n, &txlist);
}
+ struct llist_node *shuffle = llist_del_all(&ep->rdllist);
+
llist_for_each_entry_safe(epi, tmp, txlist.first, rdllink) {
init_llist_node(&epi->rdllink);
@@ -1778,6 +1780,13 @@ static int ep_send_events(struct eventpoll *ep,
}
}
+ if (shuffle) {
+ struct llist_node *last = shuffle;
+ while (last->next)
+ last = last->next;
+ llist_add_batch(shuffle, last, &ep->rdllist);
+ }
+
__pm_relax(ep->ws);
mutex_unlock(&ep->mtx);
next prev parent reply other threads:[~2025-07-11 5:02 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 9:08 Nam Cao
2025-05-30 5:08 ` Christian Brauner
2025-06-25 15:35 ` Sebastian Andrzej Siewior
2025-06-26 13:35 ` Frederic Weisbecker
2025-06-26 13:51 ` Sebastian Andrzej Siewior
2025-06-25 14:50 ` Sebastian Andrzej Siewior
2025-06-25 15:27 ` Nam Cao
2025-06-25 15:33 ` Sebastian Andrzej Siewior
2025-06-25 15:57 ` Nam Cao
2025-06-25 16:02 ` Nam Cao
2025-06-26 15:23 ` John Ogness
2025-06-26 15:49 ` Sebastian Andrzej Siewior
2025-06-26 15:56 ` Nam Cao
2025-06-30 15:08 ` K Prateek Nayak
2025-07-01 20:33 ` Florian Bezdeka
2025-07-01 12:03 ` Christian Brauner
2025-07-10 3:08 ` Xi Ruoyao
2025-07-10 3:48 ` Nam Cao
2025-07-10 4:06 ` Nam Cao
2025-07-10 4:10 ` Xi Ruoyao
2025-07-10 6:21 ` Nam Cao
2025-07-10 6:54 ` Xi Ruoyao
2025-07-10 8:32 ` Nam Cao
2025-07-10 9:47 ` Xi Ruoyao
2025-07-11 5:02 ` Nam Cao [this message]
2025-07-11 9:44 ` Christian Brauner
2025-07-11 9:48 ` Xi Ruoyao
2025-07-11 9:58 ` Nam Cao
2025-07-11 12:09 ` Xi Ruoyao
2025-07-11 12:21 ` Nam Cao
2025-07-12 0:09 ` Nam Cao
2025-07-12 8:54 ` Xi Ruoyao
2025-07-11 9:50 ` Nam Cao
2025-07-14 8:59 ` Christian Brauner
2025-07-14 10:14 ` Nam Cao
2025-07-15 9:37 ` Yann Ylavic
2025-07-15 10:08 ` Nam Cao
2025-07-14 16:16 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250711050217.OMtx7Cz6@linutronix.de \
--to=namcao@linutronix.de \
--cc=axboe@kernel.dk \
--cc=bigeasy@linutronix.de \
--cc=brauner@kernel.org \
--cc=clrkwllms@kernel.org \
--cc=frederic@kernel.org \
--cc=jack@suse.cz \
--cc=jdamato@fastly.com \
--cc=john.ogness@linutronix.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linux-rt-users@vger.kernel.org \
--cc=mkarsten@uwaterloo.ca \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=vschneid@redhat.com \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®