From: Nam Cao <namcao@linutronix.de>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
John Ogness <john.ogness@linutronix.de>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Gabriele Monaco <gmonaco@redhat.com>,
linux-trace-kernel@vger.kernel.org,
Josh Poimboeuf <jpoimboe@kernel.org>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] Fix up build issues with vpanic
Date: Fri, 11 Jul 2025 14:06:00 +0200 [thread overview]
Message-ID: <20250711120600.fIZo17WG@linutronix.de> (raw)
In-Reply-To: <20250711112844.GG1099709@noisy.programming.kicks-ass.net>
On Fri, Jul 11, 2025 at 01:28:44PM +0200, Peter Zijlstra wrote:
> On Fri, Jul 11, 2025 at 01:20:41PM +0200, Nam Cao wrote:
> > Hi,
> >
> > The newly introduced vpanic() has some build issues. This series fix them
> > up.
> >
> > As the vpanic() is only in ftrace tree for now, it is probably best to let
> > this series goes to ftrace tree, if everyone is okay with that.
>
> Does it make sense to make panic a static inline?
I think no, code size increases by a few K:
text data bss dec hex filename
12222627 6097658 479669 18799954 11edd52 vmlinux.before
12226703 6098618 479669 18804990 11ef0fe vmlinux.after
(it's riscv64, I had issue converting on x86 because there's another
definition of panic())
Maybe faster? But panic() doesn't need to be fast, it's not called in
normal circumstances anyway.
Best regards,
Nam
next prev parent reply other threads:[~2025-07-11 12:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 11:20 Nam Cao
2025-07-11 11:20 ` [PATCH 1/2] objtool: Add vpanic() to the noreturn list Nam Cao
2025-07-11 11:20 ` [PATCH 2/2] panic: Fix up description of vpanic() Nam Cao
2025-07-15 5:56 ` Masami Hiramatsu
2025-07-15 13:31 ` Nam Cao
2025-07-11 11:28 ` [PATCH 0/2] Fix up build issues with vpanic Peter Zijlstra
2025-07-11 12:06 ` Nam Cao [this message]
2025-07-11 16:24 ` Steven Rostedt
2025-07-11 18:18 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250711120600.fIZo17WG@linutronix.de \
--to=namcao@linutronix.de \
--cc=gmonaco@redhat.com \
--cc=john.ogness@linutronix.de \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®