From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Koichi Okuno <fj2767dz@fujitsu.com>
Cc: "Will Deacon" <will@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Gowthami Thiagarajan" <gthiagarajan@marvell.com>,
"Linu Cherian" <lcherian@marvell.com>,
"Robin Murphy" <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org,
"Bjorn Andersson" <quic_bjorande@quicinc.com>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Nícolas \"F. R. A. Prado\"" <nfraprado@collabora.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Peter Zijlstra" <peterz@infradead.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] perf: Fujitsu: Add the Uncore PCI PMU driver
Date: Fri, 11 Jul 2025 16:42:17 +0100 [thread overview]
Message-ID: <20250711164217.00006ea7@huawei.com> (raw)
In-Reply-To: <20250711071404.2138816-3-fj2767dz@fujitsu.com>
On Fri, 11 Jul 2025 16:13:40 +0900
Koichi Okuno <fj2767dz@fujitsu.com> wrote:
> This adds two new dynamic PMUs to the Perf Events framework to program
> and control the Uncore PCI PMUs in Fujitsu chips.
>
> These drivers were created with reference to drivers/perf/qcom_l3_pmu.c.
>
> These drivers export formatting and event information to sysfs so they can
> be used by the perf user space tools with the syntaxes:
>
> perf stat -e pci_iod0_pci0/ea-pci/ ls
> perf stat -e pci_iod0_pci0/event=0x80/ ls
>
> FUJITSU-MONAKA PMU Events Specification v1.1 URL:
> https://github.com/fujitsu/FUJITSU-MONAKA
>
> Signed-off-by: Koichi Okuno <fj2767dz@fujitsu.com>
Hi.
As much comments would be much the same as on patch 1
I'll wait for v7 to take another look at this one.
In general both are really clean drivers so just minor stuff
to work on for v7.
Thanks,
Jonathan
prev parent reply other threads:[~2025-07-11 15:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 7:13 [PATCH v6 0/2] perf: Fujitsu: Add Uncore MAC/PCI " Koichi Okuno
2025-07-11 7:13 ` [PATCH v6 1/2] perf: Fujitsu: Add the Uncore MAC " Koichi Okuno
2025-07-11 15:40 ` Jonathan Cameron
2025-07-18 6:00 ` Koichi Okuno (Fujitsu)
2025-07-11 7:13 ` [PATCH v6 2/2] perf: Fujitsu: Add the Uncore PCI " Koichi Okuno
2025-07-11 15:42 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250711164217.00006ea7@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=fj2767dz@fujitsu.com \
--cc=geert+renesas@glider.be \
--cc=gthiagarajan@marvell.com \
--cc=konradybcio@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lcherian@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=neil.armstrong@linaro.org \
--cc=nfraprado@collabora.com \
--cc=peterz@infradead.org \
--cc=quic_bjorande@quicinc.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®