From: Joel Granados <joel.granados@kernel.org>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Cc: Klaus Jensen <k.jensen@samsung.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Joel Granados <joel.granados@kernel.org>
Subject: [PATCH RFC 8/8] nvme: Connect CDQ ioctl to nvme driver
Date: Mon, 14 Jul 2025 11:15:39 +0200 [thread overview]
Message-ID: <20250714-jag-cdq-v1-8-01e027d256d5@kernel.org> (raw)
In-Reply-To: <20250714-jag-cdq-v1-0-01e027d256d5@kernel.org>
When deleting, call the nvme_cdq_delete directly as there is no
additional preparation needed. Construct the nvme admin command to
create before sending it down to the driver; this effectively sets mos
and cqs among other variables. Once the controller has returned, set the
cdq_id and cdq_fd for the ioctl caller.
Signed-off-by: Joel Granados <joel.granados@kernel.org>
---
drivers/nvme/host/ioctl.c | 47 ++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c
index ca86d3bf7ea49d0ec812640a6c0267a5aad40b79..6ab42381b6fe4e88bae341874b111ed4b7ade397 100644
--- a/drivers/nvme/host/ioctl.c
+++ b/drivers/nvme/host/ioctl.c
@@ -378,6 +378,46 @@ static int nvme_user_cmd64(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
return status;
}
+static int nvme_user_cdq(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
+ struct nvme_cdq_cmd __user *ucmd, unsigned int flags,
+ bool open_for_write)
+{
+ int status;
+ u16 cdq_id = 0;
+ int cdq_fd = 0;
+ struct nvme_command c = {};
+ struct nvme_cdq_cmd cmd = {};
+
+ if (copy_from_user(&cmd, ucmd, sizeof(cmd)))
+ return -EFAULT;
+
+ if (cmd.cdqp_offset >= cmd.entry_nbyte)
+ return -EINVAL;
+
+ c.cdq.opcode = nvme_admin_cdq;
+ c.cdq.sel = NVME_CDQ_SEL_CREATE_CDQ;
+ c.cdq.mos = cpu_to_le16(cmd.mos);
+ c.cdq.create.cdq_flags = cpu_to_le16(NVME_CDQ_CFG_PC_CONT);
+ c.cdq.create.cqs = cpu_to_le16(cmd.cqs);
+ /* >>2: size is in dwords */
+ c.cdq.cdqsize = (cmd.entry_nbyte * cmd.entry_nr) >> 2;
+
+ status = nvme_cdq_create(ctrl, &c,
+ cmd.entry_nr, cmd.entry_nbyte,
+ cmd.cdqp_offset, cmd.cdqp_mask,
+ &cdq_id, &cdq_fd);
+ if (status)
+ return status;
+
+ cmd.cdq_id = cdq_id;
+ cmd.read_fd = cdq_fd;
+
+ if (copy_to_user(ucmd, &cmd, sizeof(cmd)))
+ return -EFAULT;
+
+ return status;
+}
+
struct nvme_uring_data {
__u64 metadata;
__u64 addr;
@@ -541,7 +581,8 @@ static int nvme_uring_cmd_io(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
static bool is_ctrl_ioctl(unsigned int cmd)
{
- if (cmd == NVME_IOCTL_ADMIN_CMD || cmd == NVME_IOCTL_ADMIN64_CMD)
+ if (cmd == NVME_IOCTL_ADMIN_CMD || cmd == NVME_IOCTL_ADMIN64_CMD ||
+ cmd == NVME_IOCTL_ADMIN_CDQ)
return true;
if (is_sed_ioctl(cmd))
return true;
@@ -556,6 +597,8 @@ static int nvme_ctrl_ioctl(struct nvme_ctrl *ctrl, unsigned int cmd,
return nvme_user_cmd(ctrl, NULL, argp, 0, open_for_write);
case NVME_IOCTL_ADMIN64_CMD:
return nvme_user_cmd64(ctrl, NULL, argp, 0, open_for_write);
+ case NVME_IOCTL_ADMIN_CDQ:
+ return nvme_user_cdq(ctrl, NULL, argp, 0, open_for_write);
default:
return sed_ioctl(ctrl->opal_dev, cmd, argp);
}
@@ -874,6 +917,8 @@ long nvme_dev_ioctl(struct file *file, unsigned int cmd,
return -EACCES;
nvme_queue_scan(ctrl);
return 0;
+ case NVME_IOCTL_ADMIN_CDQ:
+ return nvme_user_cdq(ctrl, NULL, argp, 0, open_for_write);
default:
return -ENOTTY;
}
--
2.47.2
next prev parent reply other threads:[~2025-07-14 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 9:15 [PATCH RFC 0/8] nvme: Add Controller Data Queue to the " Joel Granados
2025-07-14 9:15 ` [PATCH RFC 1/8] nvme: Add CDQ command definitions for contiguous PRPs Joel Granados
2025-07-14 9:15 ` [PATCH RFC 2/8] nvme: Add cdq data structure to nvme_ctrl Joel Granados
2025-07-14 9:15 ` [PATCH RFC 3/8] nvme: Add file descriptor to read CDQs Joel Granados
2025-07-14 9:15 ` [PATCH RFC 4/8] nvme: Add function to create a CDQ Joel Granados
2025-07-14 9:15 ` [PATCH RFC 5/8] nvme: Add function to delete CDQ Joel Granados
2025-07-14 9:15 ` [PATCH RFC 6/8] nvme: Add a release ops to cdq file ops Joel Granados
2025-07-14 9:15 ` [PATCH RFC 7/8] nvme: Add Controller Data Queue (CDQ) ioctl command Joel Granados
2025-07-14 9:15 ` Joel Granados [this message]
2025-07-14 13:02 ` [PATCH RFC 0/8] nvme: Add Controller Data Queue to the nvme driver Christoph Hellwig
2025-07-18 11:33 ` Joel Granados
2025-07-21 6:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250714-jag-cdq-v1-8-01e027d256d5@kernel.org \
--to=joel.granados@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®