Re: [PATCH 1/2] objtool/rust: add one more `noreturn` Rust function for Rust 1.89.0

[Peter Zijlstra <peterz@infradead.org>]

On Mon, Jul 14, 2025 at 10:48:33AM +0200, Alice Ryhl wrote:

> > >  tools/objtool/check.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> > > index f23bdda737aa..3257eefc41ed 100644
> > > --- a/tools/objtool/check.c
> > > +++ b/tools/objtool/check.c
> > > @@ -224,6 +224,7 @@ static bool is_rust_noreturn(const struct symbol *func)
> > >              str_ends_with(func->name, "_4core9panicking14panic_explicit")                            ||
> > >              str_ends_with(func->name, "_4core9panicking14panic_nounwind")                            ||
> > >              str_ends_with(func->name, "_4core9panicking18panic_bounds_check")                        ||
> > > +            str_ends_with(func->name, "_4core9panicking18panic_nounwind_fmt")                        ||
> > >              str_ends_with(func->name, "_4core9panicking19assert_failed_inner")                       ||
> > >              str_ends_with(func->name, "_4core9panicking30panic_null_pointer_dereference")            ||
> > >              str_ends_with(func->name, "_4core9panicking36panic_misaligned_pointer_dereference")      ||
> >
> > Just having "_4core9panicking" substring is not sufficient?
> 
> That prefix just means it is defined in the panicking.rs file, which
> also has a few functions that are not noreturn.

Oh well, I figured it was too good to be true anyway. Its just that
there was a lot of that around and I had to ask :-)