mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jianfeng Liu <liujianfeng1994@gmail.com>
To: detlev.casanova@collabora.com
Cc: heiko@sntech.de, kernel@collabora.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-rockchip@lists.infradead.org, liujianfeng1994@gmail.com,
	mchehab@kernel.org, nicolas.dufresne@collabora.com,
	nicolas.frattaroli@collabora.com
Subject: Re: [PATCH 00/12] media: rkvdec: Add support for VDPU381 and VDPU383
Date: Mon, 14 Jul 2025 22:46:10 +0800	[thread overview]
Message-ID: <20250714144610.258372-1-liujianfeng1994@gmail.com> (raw)
In-Reply-To: <2229133.irdbgypaU6@trenzalore>

Hi Detlev,

On Mon, 14 Jul 2025 09:35:19, Detlev Casanova wrote:
>From the linked code, the max size is hard coded to 1920x1088.
>The driver sets the frame size type to V4L2_FRMSIZE_TYPE_CONTINUOUS, so the 
>snippet you pointed to doesn't update the values for max/min. See [2] for the 
>discussion about using V4L2_FRMSIZE_TYPE_CONTINUOUS.

You are right, the code of chromium should be fixed for frame size type
V4L2_FRMSIZE_TYPE_CONTINUOUS.

>> 2, Playing H264 videos ends up with green screen.
>
>Can you elaborate a bit ? What videos ?
>Is that on both SoCs ?
>Is there any logs in dmesg ?

I am playing a 1080p h264 BBB video[1]. There is no error logs from both
chromium and dmesg, but there is only frames refreshing at the top left
corner while the other part of place is green. This happens on both rk3399
and rk3588.

I have checked that this issue is not introduced by your series. After
reverting this commit[2] which adds Support High 10 and 4:2:2 profiles,
chromium can play video well on rk3399. I will investigate further.

[1] https://mirrors.tuna.tsinghua.edu.cn/blender/demo/movies/BBB/bbb_sunflower_1080p_60fps_normal.mp4.zip
[2] https://github.com/torvalds/linux/commit/5e1ff2314797bf53636468a97719a8222deca9ae

Best regards
Jianfeng

  reply	other threads:[~2025-07-14 14:46 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-08 15:19 Detlev Casanova
2025-07-08 15:19 ` [PATCH 01/12] media: rkvdec: Switch to using structs instead of writel Detlev Casanova
2025-07-08 15:19 ` [PATCH 02/12] media: rkvdec: Move cabac table to its own source file Detlev Casanova
2025-07-08 15:19 ` [PATCH 03/12] media: rkvdec: Use structs to represent the HW RPS Detlev Casanova
2025-07-08 15:19 ` [PATCH 04/12] media: rkvdec: Move h264 functions to common file Detlev Casanova
2025-07-08 15:19 ` [PATCH 05/12] media: rkvdec: Add per variant configuration Detlev Casanova
2025-07-08 15:19 ` [PATCH 06/12] media: rkvdec: Add RCB and SRAM support Detlev Casanova
2025-07-08 15:19 ` [PATCH 07/12] media: rkvdec: Support per-variant interrupt handler Detlev Casanova
2025-07-08 15:19 ` [PATCH 08/12] media: rkvdec: Enable all clocks without naming them Detlev Casanova
2025-07-08 15:19 ` [PATCH 09/12] media: rkvdec: Add H264 support for the VDPU381 variant Detlev Casanova
2025-07-08 15:19 ` [PATCH 10/12] media: rkvdec: Add H264 support for the VDPU383 variant Detlev Casanova
2025-07-08 15:19 ` [PATCH 11/12] media: rkvdec: Add HEVC support for the VDPU381 variant Detlev Casanova
2025-07-08 15:19 ` [PATCH 12/12] media: rkvdec: Add HEVC support for the VDPU383 variant Detlev Casanova
2025-07-13 14:25 ` Re:[PATCH 00/12] media: rkvdec: Add support for VDPU381 and VDPU383 Jianfeng Liu
2025-07-14 13:35   ` [PATCH " Detlev Casanova
2025-07-14 14:46     ` Jianfeng Liu [this message]
2025-07-18  9:37       ` Jianfeng Liu
2025-07-28 20:22         ` Nicolas Dufresne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250714144610.258372-1-liujianfeng1994@gmail.com \
    --to=liujianfeng1994@gmail.com \
    --cc=detlev.casanova@collabora.com \
    --cc=heiko@sntech.de \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mchehab@kernel.org \
    --cc=nicolas.dufresne@collabora.com \
    --cc=nicolas.frattaroli@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®