From: Greg KH <gregkh@linuxfoundation.org>
To: "Meng-Shao.Liu" <sau525@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] samples/kobject: make attribute_group const
Date: Tue, 15 Jul 2025 16:54:26 +0200 [thread overview]
Message-ID: <2025071506-bundle-fondling-6a94@gregkh> (raw)
In-Reply-To: <20250715143035.27437-1-sau525@gmail.com>
On Tue, Jul 15, 2025 at 10:30:35PM +0800, Meng-Shao.Liu wrote:
> The attr_group structures are allocated once and never modified at
> runtime. Also to match the const‑qualified parameter of
> sysfs_create_group().
>
> No functional change.
This line isn't needed, as there is a functional change, it moves it
into read-only memory, right?
thanks,
greg k-h
next prev parent reply other threads:[~2025-07-15 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 14:30 Meng-Shao.Liu
2025-07-15 14:54 ` Greg KH [this message]
2025-07-16 3:07 [PATCH 1/2] samples/kobject: fix path comment Meng Shao Liu
2025-07-16 3:07 ` [PATCH 2/2] samples/kobject: make attribute_group const Meng Shao Liu
2025-07-16 4:53 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025071506-bundle-fondling-6a94@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sau525@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®