mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Wei Fang <wei.fang@nxp.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	"F.S. Peng" <fushi.peng@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"richardcochran@gmail.com" <richardcochran@gmail.com>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Clark Wang <xiaoning.wang@nxp.com>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>
Subject: Re: [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC Timer
Date: Tue, 15 Jul 2025 10:02:56 +0300	[thread overview]
Message-ID: <20250715070256.ce6a3insjihjtpzj@skbuf> (raw)
In-Reply-To: <PAXPR04MB8510FFE0A5DA2F3A94E9CB7E8857A@PAXPR04MB8510.eurprd04.prod.outlook.com>

On Tue, Jul 15, 2025 at 05:52:33AM +0300, Wei Fang wrote:
> > You seem to imply that the "nxp,pps-channel" property affects the
> > function of the SoC pads, which may be connected to the NETC 1588 timer
> > block or to some other IP. Nothing in the code I saw suggested this
> > would be the case, and I still don't see how this is the case - but
> > anyway, my bad.
> > 
> > In this case, echoing Krzysztof's comments: How come it isn't the system
> > pinmux driver the one concerned with connecting the SoC pads to the NETC
> > 1588 timer or to FlexIO, CAN etc? The pinmux driver controls the pads,
> > the NETC timer controls its block's pins, regardless of how they are
> > routed further.
> 
> pinmux can select which device to use this pin for, but this is the
> configuration inside SoC. For the outside, depending on the design
> of the board, for example, pin0 is connected to a CAN-related device,
> then in fact this pin can only be used by CAN.

Ok, but I fail to see the relevance here? Do you just mean to say 'there
are multiple FIPER outputs from the 1588 timer block, and they may not
all be pinmuxed to SoC pads, so I intended "nxp,pps-channel" as a way
for the device tree writer to select one of the FIPER outputs which is
multiplexed to an SoC pad, rather than arbitrarily choosing one of the
FIPER channels in the driver'? If so, I believe the case is settled and
this property will disappear in v2.

  reply	other threads:[~2025-07-15  7:03 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-11  6:57 [PATCH net-next 00/12] Add NETC Timer PTP driver and add PTP support for ENETC v4 Wei Fang
2025-07-11  6:57 ` [PATCH net-next 01/12] dt-bindings: ptp: add bindings for NETC Timer Wei Fang
2025-07-11 13:27   ` Andrew Lunn
2025-07-14  2:32     ` Wei Fang
2025-07-14  5:51   ` Krzysztof Kozlowski
2025-07-14  7:32     ` Wei Fang
2025-07-14  7:35       ` Krzysztof Kozlowski
2025-07-14  9:11         ` Wei Fang
2025-07-14  9:14           ` Krzysztof Kozlowski
2025-07-14  9:56             ` Wei Fang
2025-07-14 10:09               ` Krzysztof Kozlowski
2025-07-14 10:20                 ` Krzysztof Kozlowski
2025-07-14 10:30                   ` Wei Fang
2025-07-14 10:28                 ` Wei Fang
2025-07-14 10:31                   ` Vladimir Oltean
2025-07-14 10:43                     ` Wei Fang
2025-07-14 11:37                       ` Vladimir Oltean
2025-07-14 13:22                         ` Wei Fang
2025-07-14 13:56                           ` Vladimir Oltean
2025-07-14 14:14                             ` Vladimir Oltean
2025-07-15  2:52                             ` Wei Fang
2025-07-15  7:02                               ` Vladimir Oltean [this message]
2025-07-15  7:11                                 ` Wei Fang
2025-07-14 11:24                   ` Krzysztof Kozlowski
2025-07-14 13:43                     ` Wei Fang
2025-07-14 14:04                       ` Krzysztof Kozlowski
2025-07-11  6:57 ` [PATCH net-next 02/12] ptp: netc: add NETC Timer PTP driver support Wei Fang
2025-07-11 13:25   ` Andrew Lunn
2025-07-14  2:29     ` Wei Fang
2025-07-12 10:43   ` Vadim Fedorenko
2025-07-14  2:57     ` Wei Fang
2025-07-12 11:53   ` kernel test robot
2025-07-14  5:55   ` Krzysztof Kozlowski
2025-07-14 10:11     ` Wei Fang
2025-07-11  6:57 ` [PATCH net-next 03/12] ptp: netc: add PPS support Wei Fang
2025-07-12 16:00   ` kernel test robot
2025-07-11  6:57 ` [PATCH net-next 04/12] ptp: netc: add periodic pulse output support Wei Fang
2025-07-11  6:57 ` [PATCH net-next 05/12] ptp: netc: add external trigger stamp support Wei Fang
2025-07-11  6:57 ` [PATCH net-next 06/12] ptp: netc: add debugfs support to loop back pulse signal Wei Fang
2025-07-11 13:33   ` Andrew Lunn
2025-07-14  2:33     ` Wei Fang
2025-07-11  6:57 ` [PATCH net-next 07/12] MAINTAINERS: add NETC Timer PTP clock driver section Wei Fang
2025-07-11  6:57 ` [PATCH net-next 08/12] net: enetc: save the parsed information of PTP packet to skb->cb Wei Fang
2025-07-12 10:54   ` Vadim Fedorenko
2025-07-14  3:07     ` Wei Fang
2025-07-11  6:57 ` [PATCH net-next 09/12] net: enetc: Add enetc_update_ptp_sync_msg() to process PTP sync packet Wei Fang
2025-07-12 10:58   ` Vadim Fedorenko
2025-07-11  6:57 ` [PATCH net-next 10/12] net: enetc: remove unnecessary CONFIG_FSL_ENETC_PTP_CLOCK check Wei Fang
2025-07-12 11:29   ` Vadim Fedorenko
2025-07-11  6:57 ` [PATCH net-next 11/12] net: enetc: add PTP synchronization support for ENETC v4 Wei Fang
2025-07-12 16:42   ` kernel test robot
2025-07-11  6:57 ` [PATCH net-next 12/12] net: enetc: don't update sync packet checksum if checksum offload is used Wei Fang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250715070256.ce6a3insjihjtpzj@skbuf \
    --to=vladimir.oltean@nxp.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=claudiu.manoil@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=fushi.peng@nxp.com \
    --cc=imx@lists.linux.dev \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=wei.fang@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®