From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Nathan Chancellor" <nathan@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad_sigma_delta: Select IIO_BUFFER_DMAENGINE and SPI_OFFLOAD
Date: Wed, 16 Jul 2025 08:51:20 +0100 [thread overview]
Message-ID: <20250716085120.51e8c130@jic23-huawei> (raw)
In-Reply-To: <764c464e-a45e-4d19-b9d4-a238f1ca84c0@baylibre.com>
On Tue, 15 Jul 2025 10:40:45 -0500
David Lechner <dlechner@baylibre.com> wrote:
> On 7/14/25 1:30 PM, Nathan Chancellor wrote:
> > CONFIG_AD_SIGMA_DELTA uses several symbols that it does not explicitly
> > select. If no other enabled driver selects them, the build fails with
> > either a linker failure if the driver is built in or a modpost failure
> > if the driver is a module.
> >
> > ld.lld: error: undefined symbol: devm_spi_offload_rx_stream_request_dma_chan
> > ld.lld: error: undefined symbol: devm_iio_dmaengine_buffer_setup_with_handle
> > ld.lld: error: undefined symbol: devm_spi_offload_trigger_get
> > ld.lld: error: undefined symbol: devm_spi_offload_get
> > ld.lld: error: undefined symbol: spi_offload_trigger_enable
> > ld.lld: error: undefined symbol: spi_offload_trigger_disable
> >
> > Select the necessary Kconfig symbols to include these functions in the
> > build to clear up the errors.
> >
> > Fixes: 219da3ea842a ("iio: adc: ad_sigma_delta: add SPI offload support")
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > ---
>
> Thanks for the fix.
>
> Reviewed-by: David Lechner <dlechner@baylibre.com>
>
Applied to the togreg branch of iio.git and pushed out (briefly) as
testing for 0-day to take a look.
Thanks,
Jonathan
prev parent reply other threads:[~2025-07-16 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 18:30 Nathan Chancellor
2025-07-15 15:40 ` David Lechner
2025-07-16 7:51 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716085120.51e8c130@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®