From: Simon Horman <horms@kernel.org>
To: Zqiang <qiang.zhang@linux.dev>
Cc: oneukum@suse.com, kuba@kernel.org, andrew+netdev@lunn.ch,
davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: Make init_satus() return -ENOMEM if alloc failed
Date: Wed, 16 Jul 2025 10:18:39 +0100 [thread overview]
Message-ID: <20250716091839.GM721198@horms.kernel.org> (raw)
In-Reply-To: <20250716001524.168110-1-qiang.zhang@linux.dev>
On Wed, Jul 16, 2025 at 08:15:23AM +0800, Zqiang wrote:
> This commit make init_status() return -ENOMEM, if invoke
> kmalloc() return failed.
>
> Signed-off-by: Zqiang <qiang.zhang@linux.dev>
Hi,
It seems to me that the code has been structured so that
this case is not treated as an error, and rather initialisation
that depends on it is skipped.
Are you sure this change is correct?
next prev parent reply other threads:[~2025-07-16 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 0:15 Zqiang
2025-07-16 0:15 ` [PATCH] net: usb: Remove duplicate assignments for net->pcpu_stat_type Zqiang
2025-07-16 9:19 ` Simon Horman
2025-07-16 22:11 ` Jakub Kicinski
2025-07-17 0:08 ` qiang.zhang
2025-07-21 9:50 ` patchwork-bot+netdevbpf
2025-07-16 9:18 ` Simon Horman [this message]
2025-07-17 0:04 ` [PATCH] net: usb: Make init_satus() return -ENOMEM if alloc failed qiang.zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716091839.GM721198@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=qiang.zhang@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®