mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hillf Danton <hdanton@sina.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Sean Young <sean@mess.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	syzbot+592e2ab8775dbe0bf09a@syzkaller.appspotmail.com,
	LKML <linux-kernel@vger.kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH] media: imon: make send_packet() more robust
Date: Wed, 16 Jul 2025 19:55:37 +0800	[thread overview]
Message-ID: <20250716115538.2206-1-hdanton@sina.com> (raw)
In-Reply-To: <a44d5568-48d6-44f7-af93-e1b966489a84@I-love.SAKURA.ne.jp>

On Wed, 16 Jul 2025 19:09:51 +0900 Tetsuo Handa wrote:
>On 2025/07/16 18:38, Sean Young wrote:
>> On Tue, Jul 15, 2025 at 09:30:02PM -0400, Alan Stern wrote:
>>> On Tue, Jul 15, 2025 at 09:19:18PM +0100, Sean Young wrote:
>>>> Hi Alan,
>>>>
>>>> On Sun, Jul 13, 2025 at 11:21:24AM -0400, Alan Stern wrote:
>>>>> On Sun, Jul 13, 2025 at 04:11:47PM +0800, Hillf Danton wrote:
>>>>>> [loop Alan in]
>>>>>
>>>>> I assume you're interested in the question of when to avoid resubmitting 
>>>>> URBs.
> 
> I think that what Hillf wanted to know (and I wanted maintainers of this
> driver to respond) is whether timeout of 10 seconds is reasonable
> 
Yes. In product environments like car cockpit I have option like change
to BOM if urb 10s timedout in general could be reliably reproduced twice
a month for example.

> -		/* Wait for transmission to complete (or abort) */
> -		retval = wait_for_completion_interruptible(
> -				&ictx->tx.finished);
> -		if (retval) {
> +		/* Wait for transmission to complete (or abort or timeout) */
> +		retval = wait_for_completion_interruptible_timeout(&ictx->tx.finished, 10 * HZ);
> 
> because the reproducer for this problem sometimes prevents
> usb_rx_callback_intf0() from being called. Unless we somehow
> handle such situation, the hung task reports won't go away.
> 

  reply	other threads:[~2025-07-16 11:55 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-09 14:37 [syzbot] [usb?] INFO: task hung in uevent_show (2) syzbot
2024-11-10  0:59 ` syzbot
2025-07-10 11:05   ` Hillf Danton
2025-07-10 11:59     ` [syzbot] [kernel?] " syzbot
2025-07-10 12:59   ` [syzbot] [usb?] " Hillf Danton
2025-07-10 13:25     ` [syzbot] [kernel?] " syzbot
2025-07-09  4:39 ` [syzbot] [usb?] " Tetsuo Handa
2025-07-09 14:03   ` [syzbot] [kernel?] " syzbot
2025-07-09 14:13     ` Tetsuo Handa
2025-07-09 14:27       ` Alan Stern
2025-07-09 14:44         ` Tetsuo Handa
2025-07-09 15:19           ` Alan Stern
2025-07-09 15:33             ` Tetsuo Handa
2025-07-09 15:41               ` Alan Stern
2025-07-10 10:17                 ` Tetsuo Handa
2025-07-10 14:13                   ` Alan Stern
2025-07-09 14:15   ` [syzbot] [usb?] " Tetsuo Handa
2025-07-09 14:44     ` [syzbot] [kernel?] " syzbot
2025-07-09 15:01       ` Tetsuo Handa
2025-07-11 11:09     ` [syzbot] [usb?] " Tetsuo Handa
2025-07-11 11:44       ` [syzbot] [kernel?] " syzbot
2025-07-11 11:52       ` [syzbot] [usb?] " Tetsuo Handa
2025-07-11 12:13         ` [syzbot] [kernel?] " syzbot
2025-07-11 13:34         ` [syzbot] [usb?] " Tetsuo Handa
2025-07-11 14:09           ` [syzbot] [kernel?] " syzbot
2025-07-11 15:01           ` [syzbot] [usb?] " Tetsuo Handa
2025-07-11 15:46             ` [syzbot] [kernel?] " syzbot
2025-07-12 14:40             ` [syzbot] [usb?] " Tetsuo Handa
2025-07-12 15:18               ` [syzbot] [kernel?] " syzbot
2025-07-12 15:41               ` [syzbot] [usb?] " Tetsuo Handa
2025-07-12 17:43                 ` [syzbot] [kernel?] " syzbot
2025-07-13  7:50                 ` [PATCH] media: imon: make send_packet() more robust Tetsuo Handa
2025-07-13  8:11                   ` Hillf Danton
2025-07-13 15:21                     ` Alan Stern
2025-07-15 20:19                       ` Sean Young
2025-07-16  1:30                         ` Alan Stern
2025-07-16  9:38                           ` Sean Young
2025-07-16 10:09                             ` Tetsuo Handa
2025-07-16 11:55                               ` Hillf Danton [this message]
2025-07-16 12:47                               ` Sean Young
2025-07-16 14:07                                 ` [PATCH v2] " Tetsuo Handa
2025-07-16 14:45                                   ` Alan Stern
2025-07-17 14:21                                     ` [PATCH v3] " Tetsuo Handa
2025-07-16 14:38                             ` [PATCH] " Alan Stern
2025-07-13  8:29                   ` [syzbot] [kernel?] INFO: task hung in uevent_show (2) syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250716115538.2206-1-hdanton@sina.com \
    --to=hdanton@sina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=sean@mess.org \
    --cc=stern@rowland.harvard.edu \
    --cc=syzbot+592e2ab8775dbe0bf09a@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®