mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: kernel test robot <lkp@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	"Steven Rostedt (Google)" <rostedt@goodmis.org>
Subject: Re: kernel/trace/trace_fprobe.c:1264:12: warning: stack frame size (1032) exceeds limit (1024) in 'trace_fprobe_create_cb'
Date: Wed, 16 Jul 2025 14:59:54 +0900	[thread overview]
Message-ID: <20250716145954.93465b106813127bad546ed0@kernel.org> (raw)
In-Reply-To: <202506240416.nZIhDXoO-lkp@intel.com>

On Tue, 24 Jun 2025 04:18:46 +0800
kernel test robot <lkp@intel.com> wrote:

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   86731a2a651e58953fc949573895f2fa6d456841
> commit: 57faaa04804ccbf16582f7fc7a6b986fd0c0e78c tracing: probe-events: Log error for exceeding the number of arguments
> date:   3 months ago
> config: s390-defconfig (https://download.01.org/0day-ci/archive/20250624/202506240416.nZIhDXoO-lkp@intel.com/config)
> compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project 875b36a8742437b95f623bab1e0332562c7b4b3f)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250624/202506240416.nZIhDXoO-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202506240416.nZIhDXoO-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> kernel/trace/trace_fprobe.c:1264:12: warning: stack frame size (1032) exceeds limit (1024) in 'trace_fprobe_create_cb' [-Wframe-larger-than]
>     1264 | static int trace_fprobe_create_cb(int argc, const char *argv[])
>          |            ^
>    1 warning generated.

Hmm, maybe this includes the stack consumed by internal
inlined function (trace_fprobe_create_internal()). If so,
we can allocate some temporary buffer in it.

Thanks, 

> 
> 
> vim +/trace_fprobe_create_cb +1264 kernel/trace/trace_fprobe.c
> 
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1263) 
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17 @1264) static int trace_fprobe_create_cb(int argc, const char *argv[])
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1265) {
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1266) 	struct traceprobe_parse_context ctx = {
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1267) 		.flags = TPARG_FL_KERNEL | TPARG_FL_FPROBE,
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1268) 	};
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1269) 	int ret;
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1270) 
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1271) 	trace_probe_log_init("trace_fprobe", argc, argv);
> 8275637215bd3d4 Masami Hiramatsu (Google  2025-01-17  1272) 	ret = trace_fprobe_create_internal(argc, argv, &ctx);
> b1d1e90490b6714 Masami Hiramatsu (Google  2023-08-23  1273) 	traceprobe_finish_parse(&ctx);
> 334e5519c375701 Masami Hiramatsu (Google  2023-06-06  1274) 	trace_probe_log_clear();
> 334e5519c375701 Masami Hiramatsu (Google  2023-06-06  1275) 	return ret;
> 334e5519c375701 Masami Hiramatsu (Google  2023-06-06  1276) }
> 334e5519c375701 Masami Hiramatsu (Google  2023-06-06  1277) 
> 
> :::::: The code at line 1264 was first introduced by commit
> :::::: 8275637215bd3d447b31d37f9b8231a013adb042 tracing: Adopt __free() and guard() for trace_fprobe.c
> 
> :::::: TO: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> :::::: CC: Steven Rostedt (Google) <rostedt@goodmis.org>
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

      reply	other threads:[~2025-07-16  5:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-23 20:18 kernel test robot
2025-07-16  5:59 ` Masami Hiramatsu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250716145954.93465b106813127bad546ed0@kernel.org \
    --to=mhiramat@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®