mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Damien Riégel" <damien.riegel@silabs.com>
Cc: greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org,
	linux-devel@silabs.com, Alex Elder <elder@kernel.org>,
	Johan Hovold <johan@kernel.org>
Subject: Re: [RFC 6/6] greybus: add class driver for Silabs Bluetooth
Date: Wed, 16 Jul 2025 15:23:45 +0200	[thread overview]
Message-ID: <2025071617-plant-daytime-582a@gregkh> (raw)
In-Reply-To: <20250705004036.3828-7-damien.riegel@silabs.com>

On Fri, Jul 04, 2025 at 08:40:36PM -0400, Damien Riégel wrote:
> +#include <linux/greybus.h>
> +#include <linux/skbuff.h>
> +#include <net/bluetooth/bluetooth.h>
> +#include <net/bluetooth/hci_core.h>
> +
> +#define GREYBUS_VENDOR_SILABS	0xBEEF
> +#define GREYBUS_PRODUCT_EFX	0xCAFE

Nice vendor ids :)

We really should make a file for all of the current ones, to keep track
of them.  At the least, the vendor ids should be made unique.

Overall this looks very good, a clean and small driver.  Would you have
other ones for this type of transport layer?

thanks,

greg k-h

      reply	other threads:[~2025-07-16 13:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-05  0:40 [RFC 0/6] Introducing CPC support in Greybus Damien Riégel
2025-07-05  0:40 ` [RFC 1/6] greybus: move host controller drivers comment in Makefile Damien Riégel
2025-07-16 13:20   ` Greg Kroah-Hartman
2025-07-05  0:40 ` [RFC 2/6] greybus: cpc: add core logic Damien Riégel
2025-07-16 13:21   ` Greg Kroah-Hartman
2025-07-05  0:40 ` [RFC 3/6] greybus: cpc: add SPI driver Damien Riégel
2025-07-05  0:40 ` [RFC 4/6] greybus: add API for async unidirectional transfer Damien Riégel
2025-07-16 13:21   ` Greg Kroah-Hartman
2025-07-05  0:40 ` [RFC 5/6] greybus: match device with bundle ID Damien Riégel
2025-07-16 13:19   ` Greg Kroah-Hartman
2025-07-05  0:40 ` [RFC 6/6] greybus: add class driver for Silabs Bluetooth Damien Riégel
2025-07-16 13:23   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025071617-plant-daytime-582a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=damien.riegel@silabs.com \
    --cc=elder@kernel.org \
    --cc=greybus-dev@lists.linaro.org \
    --cc=johan@kernel.org \
    --cc=linux-devel@silabs.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®