From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16EB629ACFC for ; Wed, 16 Jul 2025 20:15:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752696920; cv=none; b=oAO0BHTfIbYs4uy9wzucEd9qmbVORY8170C8DNTUm/9KyABcVPU+fHcFG/27t/4eRv1b7l3MrfHeYMrd6/oAybjZHXI0vxUUDY9xcrULFSxnRAvEadHCyeSmuESDz+aAGswUUYDsVD+ngCvmG5wXW73UChY48RAf4A0fo2+4AcI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752696920; c=relaxed/simple; bh=e2N7oTY2cgHu2RKJ+FKHz780v8w7gc4fcXnxguLDIU8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=smYZvND83KnnDDr5mxnytsdnOt6Dx+4jO1V/ujt4SXiHLTrFYz440qWhTVPshbQykf68QE6XcYYGevEDstnL62k+n9ddICHtp5HmYO/FT+tVtfwnPU0gfh1IyiQZTzhV2i9z5spkhfF4K5aqf6PqOcgO8519xbNGjWlCth7kJOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Ga+cp8yj; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ga+cp8yj" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-b31df10dfadso112170a12.0 for ; Wed, 16 Jul 2025 13:15:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1752696918; x=1753301718; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=xcRx1AnfVIz4234lB8ggVFO+piASilvu9GQSG89S72I=; b=Ga+cp8yja5uNTcns8am9fwEFgI5RjILlCJWgjbv8JrM3snOX0T6XG2/ILZdZs7lkST BImwJRcD/lh1S2Pd4fIqarL/xCCkzuNg0INcXYtTJrnPHU4KLsrMKIiLQXn3/qVMFv/3 00wvlwcNI0PEOXZoT2jPvtOloZayTpJcH0B7lbc2qE3KYjsVtqFelG7bxOkpCbayWAwy 8gIYPUFCfHBzDva11uIUZKyfMweO7nZrAgyy7/m1fehgHJTSMEzwm2jVof3rNMlXAOmI pZzsD425UWnkb8arkt5IBHwZvLKBDpDH1qxFghg3bmGPQMZOPMiyzTIgvZHjuuTuVY8N mxIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752696918; x=1753301718; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xcRx1AnfVIz4234lB8ggVFO+piASilvu9GQSG89S72I=; b=Tf5F8lR+fg1FoX4l/yrPSVOGvEbH234dX6UUCyVX0ukC2jJKbB4RYBpeoSdFYojxgr mCm6PEgIvxVWF64xcmqzj0CCbT9yfnGMU+ToeT/qNj9HyDbbs7BexN9wo4TLEVYd7zNi p/9TRhbUOdgd/upaPaSi8S85mSVUNIb18AGLTdvuW+QRWRrxY8p4FBA24oYZnn5pC2yx Qg7wMzM8CpyUQwtYwNSCXNG9dusKaDTTV2OoBEdBAbR9AnQbp7M5sLdb3QS2ICd/F/P8 C+EmQ5VYZ8s2+wFI+tkceHgwlwQw0HVYxG92lvyWCLltWrV8wpLSvETR1SoTICB+I+Va HuqQ== X-Forwarded-Encrypted: i=1; AJvYcCXv2uRbQ/gxaCiyeN/3P+RdjabB12Fh0Fo3p+rbw6xhNI/uSGLcjL7gxylphWtdIS2hVgE1E4nEo/7wBOg=@vger.kernel.org X-Gm-Message-State: AOJu0YzZYtd/d3YzRDYxrR4erdAKVdsYqqQqIxOnGDjCU/NlcuYkYH/W 9cawEWsgUKn8WonUPeh6VMyOCYIaYiNJii9gD5XmUO/UrWpQ39wjnyi85lPdSPX1vRueFDCSJiK uOLHR0ngK9g== X-Google-Smtp-Source: AGHT+IFXFIpR8tvs64KCwVrEAEYj5ZqRVuARd4HnUVyBiTRdTywmRrVQcsrH3+6kOTEgWsdaQsvJ8LZLPRA+ X-Received: from pjbst15.prod.google.com ([2002:a17:90b:1fcf:b0:313:221f:6571]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:3cc6:b0:312:1dc9:9f67 with SMTP id 98e67ed59e1d1-31c9e6e2d84mr6491611a91.2.1752696918425; Wed, 16 Jul 2025 13:15:18 -0700 (PDT) Date: Wed, 16 Jul 2025 13:15:11 -0700 In-Reply-To: <20250716201512.792052-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250716201512.792052-1-irogers@google.com> X-Mailer: git-send-email 2.50.0.727.gbf7dc18ff4-goog Message-ID: <20250716201512.792052-2-irogers@google.com> Subject: [PATCH v1 2/3] perf pmu: Switch FILENAME_MAX to NAME_MAX From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Kan Liang , James Clark , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" FILENAME_MAX is the same as PATH_MAX (4kb) in glibc rather than NAME_MAX's 255. Switch to using NAME_MAX and ensure the '\0' is accounted for in the path's buffer size. Fixes: 754baf426e09 ("perf pmu: Change aliases from list to hashmap") Signed-off-by: Ian Rogers --- tools/perf/util/pmu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index b09b2ea2407a..f3da6e27bfcb 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -453,7 +453,7 @@ static struct perf_pmu_alias *perf_pmu__find_alias(struct perf_pmu *pmu, { struct perf_pmu_alias *alias; bool has_sysfs_event; - char event_file_name[FILENAME_MAX + 8]; + char event_file_name[NAME_MAX + 8]; if (hashmap__find(pmu->aliases, name, &alias)) return alias; @@ -752,7 +752,7 @@ static int pmu_aliases_parse(struct perf_pmu *pmu) static int pmu_aliases_parse_eager(struct perf_pmu *pmu, int sysfs_fd) { - char path[FILENAME_MAX + 7]; + char path[NAME_MAX + 8]; int ret, events_dir_fd; scnprintf(path, sizeof(path), "%s/events", pmu->name); -- 2.50.0.727.gbf7dc18ff4-goog