From: Allen Ballway <ballway@chromium.org>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Allen Ballway <ballway@chromium.org>
Subject: [PATCH] media: ov8865: Preserve hflip in ov8865_mode_binning_configure
Date: Thu, 17 Jul 2025 14:07:58 -0700 [thread overview]
Message-ID: <20250717-su-v1-1-0f740fd8bfb6@chromium.org> (raw)
Prevents ov8865_mode_binning_configure from overwriting the hflip
register values. Allows programs to configure the hflip.
Signed-off-by: Allen Ballway <ballway@chromium.org>
---
drivers/media/i2c/ov8865.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
index 95ffe7536aa6aba814f4e5c3d12e7279470b2f07..40a852d31f13aff960acfd09b378d71525e19332 100644
--- a/drivers/media/i2c/ov8865.c
+++ b/drivers/media/i2c/ov8865.c
@@ -1746,7 +1746,13 @@ static int ov8865_mode_binning_configure(struct ov8865_sensor *sensor,
if (ret)
return ret;
- value = OV8865_FORMAT2_HSYNC_EN;
+ ret = ov8865_read(sensor, OV8865_FORMAT2_REG, &value);
+ if (ret)
+ return ret;
+
+ value &= OV8865_FORMAT2_FLIP_HORZ_ISP_EN |
+ OV8865_FORMAT2_FLIP_HORZ_SENSOR_EN;
+ value |= OV8865_FORMAT2_HSYNC_EN;
if (mode->binning_x)
value |= OV8865_FORMAT2_FST_HBIN_EN;
---
base-commit: 6832a9317eee280117cd695fa885b2b7a7a38daf
change-id: 20250717-su-94b187fa3d1e
Best regards,
--
Allen Ballway <ballway@chromium.org>
next reply other threads:[~2025-07-17 21:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 21:07 Allen Ballway [this message]
2025-07-21 11:51 ` Hans de Goede
2025-07-21 17:46 ` Allen Ballway
2025-07-22 9:19 ` Hans de Goede
2025-07-22 19:39 ` Allen Ballway
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250717-su-v1-1-0f740fd8bfb6@chromium.org \
--to=ballway@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®