From: "Otto Pflüger" <otto.pflueger@abscue.de>
To: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Kevin Tang <kevin.tang@unisoc.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Otto Pflüger" <otto.pflueger@abscue.de>
Subject: [PATCH 08/12] drm: sprd: add gate clock support
Date: Sat, 19 Jul 2025 14:09:44 +0200 [thread overview]
Message-ID: <20250719-ums9230-drm-v1-8-e4344a05eb3d@abscue.de> (raw)
In-Reply-To: <20250719-ums9230-drm-v1-0-e4344a05eb3d@abscue.de>
Enable the DPU and DSI gate clocks specified in the device tree.
Disable the DSI clock when it is not needed.
Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
---
drivers/gpu/drm/sprd/sprd_dpu.c | 7 +++++++
drivers/gpu/drm/sprd/sprd_dpu.h | 1 +
drivers/gpu/drm/sprd/sprd_dsi.c | 10 ++++++++++
drivers/gpu/drm/sprd/sprd_dsi.h | 4 +++-
4 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sprd/sprd_dpu.c b/drivers/gpu/drm/sprd/sprd_dpu.c
index 0d9eb778794d92418b39f8535d94abde3566de43..575bcdb0e0bb30055ac5c3d0e65178cc9f6611f3 100644
--- a/drivers/gpu/drm/sprd/sprd_dpu.c
+++ b/drivers/gpu/drm/sprd/sprd_dpu.c
@@ -3,6 +3,7 @@
* Copyright (C) 2020 Unisoc Inc.
*/
+#include <linux/clk.h>
#include <linux/component.h>
#include <linux/delay.h>
#include <linux/dma-buf.h>
@@ -794,6 +795,12 @@ static int sprd_dpu_context_init(struct sprd_dpu *dpu,
if (ctx->irq < 0)
return ctx->irq;
+ ctx->clk = devm_clk_get_optional_enabled(dev, "enable");
+ if (IS_ERR(ctx->clk)) {
+ dev_err(dev, "failed to get dpu enable clock\n");
+ return PTR_ERR(ctx->clk);
+ }
+
/* disable and clear interrupts before register dpu IRQ. */
writel(0x00, ctx->base + REG_DPU_INT_EN);
writel(0xff, ctx->base + REG_DPU_INT_CLR);
diff --git a/drivers/gpu/drm/sprd/sprd_dpu.h b/drivers/gpu/drm/sprd/sprd_dpu.h
index 157a78f24dc18b071602552ea9d005af66525263..d48b922de580a8a4bf07c4610c431d3321f7b810 100644
--- a/drivers/gpu/drm/sprd/sprd_dpu.h
+++ b/drivers/gpu/drm/sprd/sprd_dpu.h
@@ -44,6 +44,7 @@ enum {
*/
struct dpu_context {
void __iomem *base;
+ struct clk *clk;
int irq;
u8 if_type;
struct videomode vm;
diff --git a/drivers/gpu/drm/sprd/sprd_dsi.c b/drivers/gpu/drm/sprd/sprd_dsi.c
index e01d1d28fe579644ec2e0c83ec9170269932adfe..e781e6c84860402f37352e768244d88ca6ffd4c9 100644
--- a/drivers/gpu/drm/sprd/sprd_dsi.c
+++ b/drivers/gpu/drm/sprd/sprd_dsi.c
@@ -828,6 +828,8 @@ static void sprd_dsi_bridge_pre_enable(struct drm_bridge *bridge)
struct sprd_dsi *dsi = bridge_to_dsi(bridge);
struct dsi_context *ctx = &dsi->ctx;
+ clk_prepare_enable(ctx->clk);
+
if (ctx->enabled) {
drm_warn(dsi->drm, "dsi is initialized\n");
return;
@@ -875,6 +877,8 @@ static void sprd_dsi_bridge_post_disable(struct drm_bridge *bridge)
sprd_dphy_fini(ctx);
sprd_dsi_fini(ctx);
+ clk_disable_unprepare(ctx->clk);
+
ctx->enabled = false;
}
@@ -1098,6 +1102,12 @@ static int sprd_dsi_probe(struct platform_device *pdev)
if (!dsi->ctx.pll.platform)
return -EINVAL;
+ dsi->ctx.clk = devm_clk_get_optional(dev, "enable");
+ if (IS_ERR(dsi->ctx.clk)) {
+ dev_err(dev, "failed to get dsi enable clock\n");
+ return PTR_ERR(dsi->ctx.clk);
+ }
+
return mipi_dsi_host_register(&dsi->host);
}
diff --git a/drivers/gpu/drm/sprd/sprd_dsi.h b/drivers/gpu/drm/sprd/sprd_dsi.h
index 0b9f1cabe71570743cbc68a8061e95a249f27191..15e57f3f49f8e5c4f856fb496a0c88f1b0414ced 100644
--- a/drivers/gpu/drm/sprd/sprd_dsi.h
+++ b/drivers/gpu/drm/sprd/sprd_dsi.h
@@ -6,8 +6,9 @@
#ifndef __SPRD_DSI_H__
#define __SPRD_DSI_H__
-#include <linux/of.h>
+#include <linux/clk.h>
#include <linux/device.h>
+#include <linux/of.h>
#include <linux/regmap.h>
#include <video/videomode.h>
@@ -95,6 +96,7 @@ struct dphy_pll {
struct dsi_context {
void __iomem *base;
struct regmap *regmap;
+ struct clk *clk;
struct dphy_pll pll;
struct videomode vm;
bool enabled;
--
2.50.0
next prev parent reply other threads:[~2025-07-19 12:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-19 12:09 [PATCH 00/12] drm: sprd: Make the Unisoc DRM driver usable on UMS9230 Otto Pflüger
2025-07-19 12:09 ` [PATCH 01/12] dt-bindings: display: sprd: adapt for UMS9230 support Otto Pflüger
2025-07-19 13:24 ` Rob Herring (Arm)
2025-07-20 12:26 ` Krzysztof Kozlowski
2025-07-20 13:55 ` Otto Pflüger
2025-07-20 15:38 ` Krzysztof Kozlowski
2025-07-20 17:35 ` Otto Pflüger
2025-07-22 7:19 ` Krzysztof Kozlowski
2025-07-19 12:09 ` [PATCH 02/12] dt-bindings: display: sprd: allow attaching a DSI panel Otto Pflüger
2025-07-19 12:09 ` [PATCH 03/12] drm: of: try binding port parent node instead of the port itself Otto Pflüger
2025-07-28 15:41 ` Dmitry Baryshkov
2025-07-19 12:09 ` [PATCH 04/12] drm: sprd: remove plane and crtc destroy callbacks Otto Pflüger
2025-07-28 15:41 ` Dmitry Baryshkov
2025-07-19 12:09 ` [PATCH 05/12] drm: sprd: register a DSI bridge and move init code to pre_enable Otto Pflüger
2025-07-28 15:43 ` Dmitry Baryshkov
2025-07-19 12:09 ` [PATCH 06/12] drm: sprd: add support for UMS9230 DSI PLL Otto Pflüger
2025-07-19 12:09 ` [PATCH 07/12] drm: sprd: fix DSI rate and PLL setup code Otto Pflüger
2025-07-19 12:09 ` Otto Pflüger [this message]
2025-07-19 12:09 ` [PATCH 09/12] drm: sprd: add support for newer DPU versions Otto Pflüger
2025-07-19 12:09 ` [PATCH 10/12] drm: sprd: always initialize DPU and DSI registers Otto Pflüger
2025-07-19 12:09 ` [PATCH 11/12] drm: sprd: add fbdev support Otto Pflüger
2025-07-19 12:09 ` [PATCH 12/12] drm: sprd: select REGMAP in Kconfig Otto Pflüger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250719-ums9230-drm-v1-8-e4344a05eb3d@abscue.de \
--to=otto.pflueger@abscue.de \
--cc=airlied@gmail.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kevin.tang@unisoc.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®