From: Al Viro <viro@zeniv.linux.org.uk>
To: Zizhi Wo <wozizhi@huawei.com>
Cc: jack@suse.com, brauner@kernel.org, axboe@kernel.dk, hch@lst.de,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai3@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH] fs: Add additional checks for block devices during mount
Date: Sat, 19 Jul 2025 05:17:09 +0100 [thread overview]
Message-ID: <20250719041709.GI2580412@ZenIV> (raw)
In-Reply-To: <20250719024403.3452285-1-wozizhi@huawei.com>
On Sat, Jul 19, 2025 at 10:44:03AM +0800, Zizhi Wo wrote:
> mkfs.ext4 -F /dev/sdb
> mount /dev/sdb /mnt
> mknod /dev/test b 8 16 # [sdb 8:16]
> echo 1 > /sys/block/sdb/device/delete
> mount /dev/test /mnt1 # -> mount success
>
> Therefore, it is necessary to add an extra check. Solve this problem by
> checking disk_live() in super_s_dev_test().
That smells like a wrong approach... You are counting upon the failure
of setup_bdev_super() after the thing is forced on the "no reuse" path,
and that's too convoluted and brittle...
next prev parent reply other threads:[~2025-07-19 4:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-19 2:44 Zizhi Wo
2025-07-19 4:17 ` Al Viro [this message]
2025-07-19 4:46 ` Zizhi Wo
2025-07-19 12:32 ` kernel test robot
2025-07-21 1:20 ` Zizhi Wo
2025-07-21 6:47 ` Christoph Hellwig
2025-07-21 7:05 ` Zizhi Wo
2025-07-23 12:51 ` Christian Brauner
2025-07-24 7:28 ` Christoph Hellwig
2025-07-24 11:26 ` Zizhi Wo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250719041709.GI2580412@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wozizhi@huawei.com \
--cc=yangerkun@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®