From: Barret Rhoden <brho@google.com>
To: Tony Luck <tony.luck@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>
Cc: Dave Martin <Dave.Martin@arm.com>,
James Morse <james.morse@arm.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] x86/resctrl: avoid divide by 0 num_rmid
Date: Mon, 21 Jul 2025 18:00:47 +0000 [thread overview]
Message-ID: <20250721180051.3645697-1-brho@google.com> (raw)
x86_cache_max_rmid's default is -1. If the hardware or VM doesn't set
the right cpuid bits, num_rmid can be 0.
Signed-off-by: Barret Rhoden <brho@google.com>
---
I ran into this on a VM on granite rapids. I guess the VMM told the
kernel it was a GNR, but didn't set all the cache/rsctl bits.
arch/x86/kernel/cpu/resctrl/monitor.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
index c261558276cd..226dee05f96e 100644
--- a/arch/x86/kernel/cpu/resctrl/monitor.c
+++ b/arch/x86/kernel/cpu/resctrl/monitor.c
@@ -359,6 +359,12 @@ int __init rdt_get_mon_l3_config(struct rdt_resource *r)
else if (mbm_offset > MBM_CNTR_WIDTH_OFFSET_MAX)
pr_warn("Ignoring impossible MBM counter offset\n");
+ if (r->num_rmid < 1) {
+ pr_warn("Invalid num_rmid %d, cach_max_rmid was %d\n",
+ r->num_rmid, boot_cpu_data.x86_cache_max_rmid);
+ r->num_rmid = 1;
+ }
+
/*
* A reasonable upper limit on the max threshold is the number
* of lines tagged per RMID if all RMIDs have the same number of
--
2.50.0.727.gbf7dc18ff4-goog
next reply other threads:[~2025-07-21 18:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 18:00 Barret Rhoden [this message]
2025-07-22 18:19 ` Reinette Chatre
2025-07-22 18:51 ` Barret Rhoden
2025-07-22 21:16 ` Reinette Chatre
2025-07-22 21:33 ` Reinette Chatre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250721180051.3645697-1-brho@google.com \
--to=brho@google.com \
--cc=Dave.Martin@arm.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®