Re: [PATCH 9/9] dt-bindings: nvmem: mediatek: efuse: Add support for MT8196

[Laura Nao <laura.nao@collabora.com>]

On 7/22/25 11:04, AngeloGioacchino Del Regno wrote:
> Il 21/07/25 10:14, Laura Nao ha scritto:
>> Add compatible for MT8196 SoC.
>>
>
> This is compatible with MT8186's layout - not with the others - and
> besides: "mediatek,efuse" is deprecated.
>
> Adding something to deprecated bindings is not even really permitted (unless
> there's a *very* good reason to, which you definitely don't have in this case).
>
> Also, this commit has no description - repeating the same as the title adds
> no information and doesn't help at all.
>
> NACK.
>

Got it, thanks both for the feedback - I'll fix this in the next 
revision.

Best,

Laura

> Regards,
> Angelo
>
>> Signed-off-by: Laura Nao <laura.nao@collabora.com>
>> ---
>>   Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
>> index 32b8c1eb4e80..e209a1132a26 100644
>> --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
>> +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
>> @@ -37,6 +37,7 @@ properties:
>>                 - mediatek,mt8188-efuse
>>                 - mediatek,mt8192-efuse
>>                 - mediatek,mt8195-efuse
>> +              - mediatek,mt8196-efuse
>>                 - mediatek,mt8516-efuse
>>             - const: mediatek,efuse
>>         - const: mediatek,mt8173-efuse 
>
>
>