mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Costa Shulyupin <costa.shul@redhat.com>
Cc: Tomas Glozar <tglozar@redhat.com>, John Kacur <jkacur@redhat.com>,
	Eder Zulian <ezulian@redhat.com>,
	Dan Carpenter <dan.carpenter@linaro.org>,
	Gabriele Monaco <gmonaco@redhat.com>,
	Jan Stancek <jstancek@redhat.com>,
	linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org,
	bpf@vger.kernel.org
Subject: Re: [PATCH v1] tools/rtla: Consolidate common parameters into shared structure
Date: Tue, 22 Jul 2025 20:04:13 -0400	[thread overview]
Message-ID: <20250722200413.4a3b3777@gandalf.local.home> (raw)
In-Reply-To: <20250701060337.648475-1-costa.shul@redhat.com>

On Tue,  1 Jul 2025 09:03:14 +0300
Costa Shulyupin <costa.shul@redhat.com> wrote:

> timerlat_params and osnoise_params structures contain 17 identical
> fields.
> 
> Introduce a common_params structure and move those fields into it to
> eliminate the code duplication and improve maintainability.

I have no preference about this patch, but would like an acked-by or
reviewed-by from Tomas and/or Gabriele.

Thanks,

-- Steve


> 
> Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>
> ---
>  tools/tracing/rtla/src/osnoise.c       |  24 ++---
>  tools/tracing/rtla/src/osnoise.h       |  19 +---
>  tools/tracing/rtla/src/osnoise_hist.c  | 112 ++++++++++-----------
>  tools/tracing/rtla/src/osnoise_top.c   | 102 +++++++++----------
>  tools/tracing/rtla/src/timerlat.c      |  24 ++---
>  tools/tracing/rtla/src/timerlat.h      |  19 +---
>  tools/tracing/rtla/src/timerlat_bpf.c  |   4 +-
>  tools/tracing/rtla/src/timerlat_hist.c | 129 +++++++++++++------------
>  tools/tracing/rtla/src/timerlat_top.c  | 121 +++++++++++------------
>  tools/tracing/rtla/src/utils.h         |  31 ++++++
>  10 files changed, 292 insertions(+), 293 deletions(-)
> 

  reply	other threads:[~2025-07-23  0:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-01  6:03 Costa Shulyupin
2025-07-23  0:04 ` Steven Rostedt [this message]
2025-07-25 12:02 ` Tomas Glozar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250722200413.4a3b3777@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=bpf@vger.kernel.org \
    --cc=costa.shul@redhat.com \
    --cc=dan.carpenter@linaro.org \
    --cc=ezulian@redhat.com \
    --cc=gmonaco@redhat.com \
    --cc=jkacur@redhat.com \
    --cc=jstancek@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=tglozar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®