From: Kees Cook <kees@kernel.org>
To: Tiffany Yang <ynaffit@google.com>
Cc: linux-kernel@vger.kernel.org,
"Carlos Llamas" <cmllamas@google.com>,
"Joel Fernandes" <joelagnelf@nvidia.com>,
kernel-team@android.com,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Christian Brauner" <brauner@kernel.org>,
"Suren Baghdasaryan" <surenb@google.com>
Subject: Re: [PATCH v2 2/2] binder: Use seq_buf in binder_alloc kunit tests
Date: Wed, 23 Jul 2025 00:32:53 -0700 [thread overview]
Message-ID: <202507230032.742E5A52E6@keescook> (raw)
In-Reply-To: <20250722234508.232228-2-ynaffit@google.com>
On Tue, Jul 22, 2025 at 04:45:07PM -0700, Tiffany Yang wrote:
> Replace instances of snprintf with seq_buf functions, as suggested by
> Kees [1].
>
> [1] https://lore.kernel.org/all/202507160743.15E8044@keescook/
>
> Fixes: d1934ed9803c ("binder: encapsulate individual alloc test cases")
> Suggested-by: Kees Cook <kees@kernel.org>
> Cc: Joel Fernandes <joelagnelf@nvidia.com>
> Signed-off-by: Tiffany Yang <ynaffit@google.com>
> ---
> This patch is based on top of char-misc-next.
> ---
> drivers/android/tests/binder_alloc_kunit.c | 46 ++++++++++------------
> 1 file changed, 21 insertions(+), 25 deletions(-)
Yay, always nice to see using an alternative API results in fewer lines! :)
Reviewed-by: Kees Cook <kees@kernel.org>
--
Kees Cook
next prev parent reply other threads:[~2025-07-23 7:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 23:45 [PATCH v2 1/2] binder: Add copyright notice to new kunit files Tiffany Yang
2025-07-22 23:45 ` [PATCH v2 2/2] binder: Use seq_buf in binder_alloc kunit tests Tiffany Yang
2025-07-23 7:32 ` Kees Cook [this message]
2025-07-25 19:38 ` Carlos Llamas
2025-07-25 19:38 ` [PATCH v2 1/2] binder: Add copyright notice to new kunit files Carlos Llamas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202507230032.742E5A52E6@keescook \
--to=kees@kernel.org \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=joelagnelf@nvidia.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=surenb@google.com \
--cc=tkjos@android.com \
--cc=ynaffit@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®