From: Steven Rostedt <rostedt@goodmis.org>
To: Ivan Pravdin <ipravdin.official@gmail.com>
Cc: bristot@kernel.org, corbet@lwn.net,
linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtla: clarify trace option syntax in documentation and usage help
Date: Thu, 24 Jul 2025 09:56:27 -0400 [thread overview]
Message-ID: <20250724095627.572c1cff@batman.local.home> (raw)
In-Reply-To: <20250723015233.173630-1-ipravdin.official@gmail.com>
On Tue, 22 Jul 2025 21:52:33 -0400
Ivan Pravdin <ipravdin.official@gmail.com> wrote:
> When using `rtla timerlat {top,hist}`, the `-t/--trace` option is
> optional. However, when providing a filename, the long option requires
> an equal sign (`=`), i.e., `--trace=<file>`. This is because the
> command-line parser treats `--trace` without `=` as a flag with no
> value, leading to unexpected behavior.
>
> Valid usage:
> - `-t[file]`
> - `-t=[file]`
> - `--trace=[file]`
>
> Invalid usage:
> - `-t [file]`
> - `--trace [file]`
I wonder if the better fix would be to make the above valid?
-- Steve
>
> Clarify valid usage in documentation and help message.
>
> Signed-off-by: Ivan Pravdin <ipravdin.official@gmail.com>
next prev parent reply other threads:[~2025-07-24 13:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 1:52 Ivan Pravdin
2025-07-24 13:56 ` Steven Rostedt [this message]
2025-07-25 9:13 ` Tomas Glozar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724095627.572c1cff@batman.local.home \
--to=rostedt@goodmis.org \
--cc=bristot@kernel.org \
--cc=corbet@lwn.net \
--cc=ipravdin.official@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®