From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C7D726C397; Thu, 24 Jul 2025 11:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753355526; cv=none; b=E1ikWcUDk+dfJhlN+JfgL75BBSbkyQ2PXVbJc4mrDgWvlnSF7IAUp4RGJEHct3gdQarrqeiq7AQEU9kRKKA7DvK10m9OElz291uZB777nsdSy1PiU6dmsWP6Lx83R785NocrCQBpsoRJprbyBaJkQCjXD3aS1Bo8axnyo2rSr6Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753355526; c=relaxed/simple; bh=HNHkkKC0N4jIHXpNvr7bCdEn66WfCk+E8NxYfBuqcA4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lo3+wTAn3ocrU9aKCg08/3DszH8V3CCI8ECR1w64yqaRDNvnuPPIJRKmGHWxIz+UotgPZURZs2lZHkXaBFv+uh7PzVOPu19CWeaS6Il78A5uX/DsfiZNFponx5aRkB6xZGgHNrw1CCu3adyYYRqF7Krnz0oPKGqi228/37LQgkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UV1fN0XX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UV1fN0XX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC8ADC4CEED; Thu, 24 Jul 2025 11:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753355526; bh=HNHkkKC0N4jIHXpNvr7bCdEn66WfCk+E8NxYfBuqcA4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=UV1fN0XXaBxI2D1pkJ82aMeHuGE49OlflDhaM8xIeVxBySrE/KqBb1+sOOzKgpP+5 dgc45IcjlxyUH/mb4HXaEEbf2Y3HZiz/eB2PRAuygK925we9XjDa6lNXXp05dQEDxe qjdg42Z1f2aroKU/2tBqAe/AjEWkG3Op7kLXJMA5DiyP7tEeqpv1/Y55yb1VPGqCwc ShtsziosVPz4vE2NEx4lGqEPRWD+UiN0B/USg0AnXP2tSZI8tW+dC+rhWOxik40b0O jHaeLEY+g+Axu2bHEU0Qkou3uYq/KDSMxVwr0VjyO/d1WEbT6W4vC/6RdM4cL/2Ti0 G+1ubdqfBjoZg== Date: Thu, 24 Jul 2025 12:11:58 +0100 From: Jonathan Cameron To: Nuno =?UTF-8?B?U8Oh?= Cc: David Lechner , Andreas Klinger , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] iio: proximity: srf08: use stack allocated scan buffer Message-ID: <20250724121158.05fb8458@jic23-huawei> In-Reply-To: References: <20250721-iio-use-more-iio_declare_buffer_with_ts-6-v2-1-8b66e5b4e75a@baylibre.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Tue, 22 Jul 2025 10:10:38 +0100 Nuno S=C3=A1 wrote: > On Mon, Jul 21, 2025 at 05:21:08PM -0500, David Lechner wrote: > > Use a stack allocated scan struct in srf08_trigger_handler(). Since the > > scan buffer isn't used outside of this function and doesn't need to be > > DMA-safe, it doesn't need to be in struct srf08_data. We can also > > eliminate an extra local variable for the return value of > > srf08_read_ranging() by using scan.chan directly. > >=20 > > Reviewed-by: Andreas Klinger > > Signed-off-by: David Lechner > > --- > > Changes in v2: > > - Zero-init the scan struct to avoid leaking uninitialized stack to use= rspace. > > - Link to v1: https://lore.kernel.org/r/20250711-iio-use-more-iio_decla= re_buffer_with_ts-6-v1-1-25c70b990d6c@baylibre.com > > --- =20 >=20 > Reviewed-by: Nuno S=C3=A1 Applied to the testing branch of iio.git. Thanks, Jonathan