From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: "Salah Triki" <salah.triki@gmail.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7280a: Remove unused macros
Date: Thu, 24 Jul 2025 12:28:09 +0100 [thread overview]
Message-ID: <20250724122809.11971471@jic23-huawei> (raw)
In-Reply-To: <5j6qcum4oi4cgnzplmnd4xqx2aothhqpk5votscc6v56xdnlwa@gt6x3ugjyr45>
On Thu, 24 Jul 2025 12:06:20 +0100
Nuno Sá <noname.nuno@gmail.com> wrote:
> On Thu, Jul 24, 2025 at 11:54:23AM +0100, Salah Triki wrote:
> > This is to fix the following warnings when compiling the ad7280a driver using
> > LLVM=1 and W=2:
> >
> > drivers/iio/adc/ad7280a.c:60:13: warning: macro is not used [-Wunused-macros]
> > 60 | #define AD7280A_CTRL_HB_CONV_AVG_4 2
> > | ^
> > drivers/iio/adc/ad7280a.c:97:9: warning: macro is not used [-Wunused-macros]
> > 97 | #define AD7280A_CB4_TIMER_REG 0x18 /* D7 to D0, Read/write */
> > | ^
> > drivers/iio/adc/ad7280a.c:120:9: warning: macro is not used [-Wunused-macros]
> > 120 | #define AD7280A_TRANS_READ_CRC_MSK GENMASK(9, 2)
> > | ^
> > drivers/iio/adc/ad7280a.c:33:9: warning: macro is not used [-Wunused-macros]
> > 33 | #define AD7280A_CELL_VOLTAGE_5_REG 0x4 /* D11 to D0, Read only */
> > | ^
> > drivers/iio/adc/ad7280a.c:99:9: warning: macro is not used [-Wunused-macros]
> > 99 | #define AD7280A_CB6_TIMER_REG 0x1A /* D7 to D0, Read/write */
> > | ^
> > drivers/iio/adc/ad7280a.c:30:9: warning: macro is not used [-Wunused-macros]
> > 30 | #define AD7280A_CELL_VOLTAGE_2_REG 0x1 /* D11 to D0, Read only */
> > | ^
> > drivers/iio/adc/ad7280a.c:52:13: warning: macro is not used [-Wunused-macros]
> > 52 | #define AD7280A_CTRL_HB_CONV_RREAD_6CELL 2
> > | ^
> > drivers/iio/adc/ad7280a.c:58:13: warning: macro is not used [-Wunused-macros]
> > 58 | #define AD7280A_CTRL_HB_CONV_AVG_DIS 0
> > | ^
> > drivers/iio/adc/ad7280a.c:59:13: warning: macro is not used [-Wunused-macros]
> > 59 | #define AD7280A_CTRL_HB_CONV_AVG_2 1
> > | ^
> > drivers/iio/adc/ad7280a.c:46:13: warning: macro is not used [-Wunused-macros]
> > 46 | #define AD7280A_CTRL_HB_CONV_INPUT_6CELL_AUX1_3_5 1
> > | ^
> > drivers/iio/adc/ad7280a.c:37:9: warning: macro is not used [-Wunused-macros]
> > 37 | #define AD7280A_AUX_ADC_3_REG 0x8 /* D11 to D0, Read only */
> > | ^
> > drivers/iio/adc/ad7280a.c:39:9: warning: macro is not used [-Wunused-macros]
> > 39 | #define AD7280A_AUX_ADC_5_REG 0xA /* D11 to D0, Read only */
> > | ^
> > drivers/iio/adc/ad7280a.c:32:9: warning: macro is not used [-Wunused-macros]
> > 32 | #define AD7280A_CELL_VOLTAGE_4_REG 0x3 /* D11 to D0, Read only */
> > | ^
> > drivers/iio/adc/ad7280a.c:41:9: warning: macro is not used [-Wunused-macros]
> > 41 | #define AD7280A_SELF_TEST_REG 0xC /* D11 to D0, Read only */
> > | ^
> > drivers/iio/adc/ad7280a.c:96:9: warning: macro is not used [-Wunused-macros]
> > 96 | #define AD7280A_CB3_TIMER_REG 0x17 /* D7 to D0, Read/write */
> > | ^
> > drivers/iio/adc/ad7280a.c:98:9: warning: macro is not used [-Wunused-macros]
> > 98 | #define AD7280A_CB5_TIMER_REG 0x19 /* D7 to D0, Read/write */
> > | ^
> > drivers/iio/adc/ad7280a.c:85:13: warning: macro is not used [-Wunused-macros]
> > 85 | #define AD7280A_ALERT_REMOVE_AUX3_AUX5 BIT(1)
> > | ^
> > drivers/iio/adc/ad7280a.c:138:9: warning: macro is not used [-Wunused-macros]
> > 138 | #define AD7280A_DEVADDR_ALL 0x1F
> > | ^
> > drivers/iio/adc/ad7280a.c:100:9: warning: macro is not used [-Wunused-macros]
> > 100 | #define AD7280A_PD_TIMER_REG 0x1B /* D7 to D0, Read/write */
> > | ^
> > drivers/iio/adc/ad7280a.c:74:11: warning: macro is not used [-Wunused-macros]
> > 74 | #define AD7280A_CTRL_LB_INC_DEV_ADDR_MSK BIT(1)
> > | ^
> > drivers/iio/adc/ad7280a.c:61:13: warning: macro is not used [-Wunused-macros]
> > 61 | #define AD7280A_CTRL_HB_CONV_AVG_8 3
> > | ^
> > drivers/iio/adc/ad7280a.c:31:9: warning: macro is not used [-Wunused-macros]
> > 31 | #define AD7280A_CELL_VOLTAGE_3_REG 0x2 /* D11 to D0, Read only */
> > | ^
> > drivers/iio/adc/ad7280a.c:51:13: warning: macro is not used [-Wunused-macros]
> > 51 | #define AD7280A_CTRL_HB_CONV_RREAD_6CELL_AUX1_3_5 1
> > | ^
> > drivers/iio/adc/ad7280a.c:47:13: warning: macro is not used [-Wunused-macros]
> > 47 | #define AD7280A_CTRL_HB_CONV_INPUT_6CELL 2
> > | ^
> > drivers/iio/adc/ad7280a.c:84:13: warning: macro is not used [-Wunused-macros]
> > 84 | #define AD7280A_ALERT_REMOVE_AUX5 BIT(0)
> > | ^
> > drivers/iio/adc/ad7280a.c:103:9: warning: macro is not used [-Wunused-macros]
> > 103 | #define AD7280A_CNVST_CTRL_REG 0x1D /* D7 to D0, Read/write */
> > | ^
> > drivers/iio/adc/ad7280a.c:55:13: warning: macro is not used [-Wunused-macros]
> > 55 | #define AD7280A_CTRL_HB_CONV_START_CNVST 0
> > | ^
> > drivers/iio/adc/ad7280a.c:36:9: warning: macro is not used [-Wunused-macros]
> > 36 | #define AD7280A_AUX_ADC_2_REG 0x7 /* D11 to D0, Read only */
> > | ^
> > drivers/iio/adc/ad7280a.c:119:9: warning: macro is not used [-Wunused-macros]
> > 119 | #define AD7280A_TRANS_READ_WRITE_ACK_MSK BIT(10)
> > | ^
> > drivers/iio/adc/ad7280a.c:38:9: warning: macro is not used [-Wunused-macros]
> > 38 | #define AD7280A_AUX_ADC_4_REG 0x9 /* D11 to D0, Read only */
> > | ^
> > drivers/iio/adc/ad7280a.c:95:9: warning: macro is not used [-Wunused-macros]
> > 95 | #define AD7280A_CB2_TIMER_REG 0x16 /* D7 to D0, Read/write */
> > | ^
> > drivers/iio/adc/ad7280a.c:48:13: warning: macro is not used [-Wunused-macros]
> > 48 | #define AD7280A_CTRL_HB_CONV_INPUT_SELF_TEST 3
> > | ^
> >
>
> Please crop the commit message. No need to past all the compiler output
> to make your point valid. This bloats the commit message a lot :)
>
> > Signed-off-by: Salah Triki <salah.triki@gmail.com>
> > ---
>
> Some people do like to have all of the register map defined even if not
> used. I personally don't... So, with the commit message improved:
I take the view this is up to a driver submitter when it comes to register
maps. As such I'd rather we didn't go dropping these.
This is particularly true when it results in a partial register definition
which some of these do.
Building with W=2 is optimistic :) I want IIO to be W=1 clean but
stuff gets stuck under there (like the exports.h missing include thing)
because they are annoying to normal people!
Jonathan
>
> Reviewed-by: Nuno Sá <nuno.sa@analog.com>
>
> > drivers/iio/adc/ad7280a.c | 32 --------------------------------
> > 1 file changed, 32 deletions(-)
> >
> > diff --git a/drivers/iio/adc/ad7280a.c b/drivers/iio/adc/ad7280a.c
> > index dda2986ccda0..cf2d70c959b3 100644
> > --- a/drivers/iio/adc/ad7280a.c
> > +++ b/drivers/iio/adc/ad7280a.c
> > @@ -27,38 +27,19 @@
> > /* Registers */
> >
> > #define AD7280A_CELL_VOLTAGE_1_REG 0x0 /* D11 to D0, Read only */
> > -#define AD7280A_CELL_VOLTAGE_2_REG 0x1 /* D11 to D0, Read only */
> > -#define AD7280A_CELL_VOLTAGE_3_REG 0x2 /* D11 to D0, Read only */
> > -#define AD7280A_CELL_VOLTAGE_4_REG 0x3 /* D11 to D0, Read only */
> > -#define AD7280A_CELL_VOLTAGE_5_REG 0x4 /* D11 to D0, Read only */
> > #define AD7280A_CELL_VOLTAGE_6_REG 0x5 /* D11 to D0, Read only */
> > #define AD7280A_AUX_ADC_1_REG 0x6 /* D11 to D0, Read only */
> > -#define AD7280A_AUX_ADC_2_REG 0x7 /* D11 to D0, Read only */
> > -#define AD7280A_AUX_ADC_3_REG 0x8 /* D11 to D0, Read only */
> > -#define AD7280A_AUX_ADC_4_REG 0x9 /* D11 to D0, Read only */
> > -#define AD7280A_AUX_ADC_5_REG 0xA /* D11 to D0, Read only */
> > #define AD7280A_AUX_ADC_6_REG 0xB /* D11 to D0, Read only */
> > -#define AD7280A_SELF_TEST_REG 0xC /* D11 to D0, Read only */
> >
> > #define AD7280A_CTRL_HB_REG 0xD /* D15 to D8, Read/write */
> > #define AD7280A_CTRL_HB_CONV_INPUT_MSK GENMASK(7, 6)
> > #define AD7280A_CTRL_HB_CONV_INPUT_ALL 0
> > -#define AD7280A_CTRL_HB_CONV_INPUT_6CELL_AUX1_3_5 1
> > -#define AD7280A_CTRL_HB_CONV_INPUT_6CELL 2
> > -#define AD7280A_CTRL_HB_CONV_INPUT_SELF_TEST 3
> > #define AD7280A_CTRL_HB_CONV_RREAD_MSK GENMASK(5, 4)
> > #define AD7280A_CTRL_HB_CONV_RREAD_ALL 0
> > -#define AD7280A_CTRL_HB_CONV_RREAD_6CELL_AUX1_3_5 1
> > -#define AD7280A_CTRL_HB_CONV_RREAD_6CELL 2
> > #define AD7280A_CTRL_HB_CONV_RREAD_NO 3
> > #define AD7280A_CTRL_HB_CONV_START_MSK BIT(3)
> > -#define AD7280A_CTRL_HB_CONV_START_CNVST 0
> > #define AD7280A_CTRL_HB_CONV_START_CS 1
> > #define AD7280A_CTRL_HB_CONV_AVG_MSK GENMASK(2, 1)
> > -#define AD7280A_CTRL_HB_CONV_AVG_DIS 0
> > -#define AD7280A_CTRL_HB_CONV_AVG_2 1
> > -#define AD7280A_CTRL_HB_CONV_AVG_4 2
> > -#define AD7280A_CTRL_HB_CONV_AVG_8 3
> > #define AD7280A_CTRL_HB_PWRDN_SW BIT(0)
> >
> > #define AD7280A_CTRL_LB_REG 0xE /* D7 to D0, Read/write */
> > @@ -71,7 +52,6 @@
> > #define AD7280A_CTRL_LB_MUST_SET BIT(4)
> > #define AD7280A_CTRL_LB_THERMISTOR_MSK BIT(3)
> > #define AD7280A_CTRL_LB_LOCK_DEV_ADDR_MSK BIT(2)
> > -#define AD7280A_CTRL_LB_INC_DEV_ADDR_MSK BIT(1)
> > #define AD7280A_CTRL_LB_DAISY_CHAIN_RB_MSK BIT(0)
> >
> > #define AD7280A_CELL_OVERVOLTAGE_REG 0xF /* D7 to D0, Read/write */
> > @@ -81,8 +61,6 @@
> >
> > #define AD7280A_ALERT_REG 0x13 /* D7 to D0, Read/write */
> > #define AD7280A_ALERT_REMOVE_MSK GENMASK(3, 0)
> > -#define AD7280A_ALERT_REMOVE_AUX5 BIT(0)
> > -#define AD7280A_ALERT_REMOVE_AUX3_AUX5 BIT(1)
> > #define AD7280A_ALERT_REMOVE_VIN5 BIT(2)
> > #define AD7280A_ALERT_REMOVE_VIN4_VIN5 BIT(3)
> > #define AD7280A_ALERT_GEN_STATIC_HIGH BIT(6)
> > @@ -92,15 +70,8 @@
> > #define AD7280A_CELL_BALANCE_CHAN_BITMAP_MSK GENMASK(7, 2)
> > #define AD7280A_CB1_TIMER_REG 0x15 /* D7 to D0, Read/write */
> > #define AD7280A_CB_TIMER_VAL_MSK GENMASK(7, 3)
> > -#define AD7280A_CB2_TIMER_REG 0x16 /* D7 to D0, Read/write */
> > -#define AD7280A_CB3_TIMER_REG 0x17 /* D7 to D0, Read/write */
> > -#define AD7280A_CB4_TIMER_REG 0x18 /* D7 to D0, Read/write */
> > -#define AD7280A_CB5_TIMER_REG 0x19 /* D7 to D0, Read/write */
> > -#define AD7280A_CB6_TIMER_REG 0x1A /* D7 to D0, Read/write */
> > -#define AD7280A_PD_TIMER_REG 0x1B /* D7 to D0, Read/write */
> > #define AD7280A_READ_REG 0x1C /* D7 to D0, Read/write */
> > #define AD7280A_READ_ADDR_MSK GENMASK(7, 2)
> > -#define AD7280A_CNVST_CTRL_REG 0x1D /* D7 to D0, Read/write */
> >
> > /* Transfer fields */
> > #define AD7280A_TRANS_WRITE_DEVADDR_MSK GENMASK(31, 27)
> > @@ -116,8 +87,6 @@
> > #define AD7280A_TRANS_READ_CONV_DATA_MSK GENMASK(22, 11)
> > #define AD7280A_TRANS_READ_REG_REGADDR_MSK GENMASK(26, 21)
> > #define AD7280A_TRANS_READ_REG_DATA_MSK GENMASK(20, 13)
> > -#define AD7280A_TRANS_READ_WRITE_ACK_MSK BIT(10)
> > -#define AD7280A_TRANS_READ_CRC_MSK GENMASK(9, 2)
> >
> > /* Magic value used to indicate this special case */
> > #define AD7280A_ALL_CELLS (0xAD << 16)
> > @@ -135,7 +104,6 @@
> > (c) - AD7280A_CELLS_PER_DEV)
> >
> > #define AD7280A_DEVADDR_MASTER 0
> > -#define AD7280A_DEVADDR_ALL 0x1F
> >
> > static const unsigned short ad7280a_n_avg[4] = {1, 2, 4, 8};
> > static const unsigned short ad7280a_t_acq_ns[4] = {470, 1030, 1510, 1945};
> > --
> > 2.43.0
> >
next prev parent reply other threads:[~2025-07-24 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 10:54 Salah Triki
2025-07-24 11:06 ` Nuno Sá
2025-07-24 11:28 ` Jonathan Cameron [this message]
2025-07-24 12:02 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724122809.11971471@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
--cc=salah.triki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®