From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C39223BCF5 for ; Thu, 24 Jul 2025 22:10:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753395037; cv=none; b=NRPao5WerTRzBJrL5Vw4PnN1SKuh7CimtyJfXZ0FhUl65YirO3jmOOSeZaOUAndWsvbK6Wc5eExKt/mTSkUp8uIHE+ACXMT0x+MElMglkad94Nbvg6hq9+kzzzg4UJhcDXinP6DN50VgtAHle1dKpgQU1mr+0xhOVYoxIaCfmg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753395037; c=relaxed/simple; bh=TNnLDIq21qsztRWhB2H8GUnroBWBk5YryXZ3YPgkilU=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=rj+IG49PzoEHaH+pUA32hbBleDRAwUdrPCSmx/1dXMHqDpYpe3M9a7uGIfngqlZ1MRPlb831t3ePAn2FtoiQLhxjm9+jcP3Ll3UzVyzecwQcxxZYpjgCxWYJYWQDkK/X66g57ALBIPfh4LrYainQjVs6zYGWBD/6oUhpZaYsLHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=LxqejKLT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="LxqejKLT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D287FC4CEF5; Thu, 24 Jul 2025 22:10:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1753395036; bh=TNnLDIq21qsztRWhB2H8GUnroBWBk5YryXZ3YPgkilU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LxqejKLTOrjfJlTdd8QtRgq8O3+ZV5i/Xx6TN+4619+k3cK4CbQ+zmWrehnKzGwXu Lqr060kOgt0mT+KylJQ6A9ONo79h0DQ9kny2ZHtd14LWGv+121HU0b4QHzOK17SDCF 7XlCCxvlNo/iMkPXddeaY7PgWY7tmjQYRvWlO/oU= Date: Thu, 24 Jul 2025 15:10:35 -0700 From: Andrew Morton To: Lance Yang Cc: Ye Liu , Ye Liu , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] hung_task: Add detection count to hung task warning message Message-Id: <20250724151035.cc2d421d1b1ed20b89be1917@linux-foundation.org> In-Reply-To: References: <20250724072326.2031432-1-ye.liu@linux.dev> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 24 Jul 2025 20:06:52 +0800 Lance Yang wrote: > > > On 2025/7/24 15:23, Ye Liu wrote: > > From: Ye Liu > > > > Add [#N] to hung task warnings to show occurrence count. > > This helps quickly identify warning order when multiple > > messages appear in logs. > > Hmm... once we have this number, what do we do with it? Yes, adding to the changelog a more comprehensive description of the use-cases would help get this patch into Linux. > While I totally get the desire for a quick reference number, my thinking > is that the hung_task_detect_count counter is the intended and more > reliable way for users to check. But that's what this patch does? Confused. > But like I said before, let's see what Andrew thinks ;) Andrew thinks it's a pain when the title of a patch is changed! Fortunately the changelog had a "Link to v1".