From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AAB41991DD; Thu, 24 Jul 2025 15:28:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753370899; cv=none; b=TcEBegy6LiLuZsXN+JNtPj/w7SbQYzvZjzVQlFIZhYPtJ3G48bcgdrFwo9wubSeViN+z8/5OWQqntaQfwxINnjP6u6Fv0iWCl5wB3yBTm5h6W4eAwJazYH6CCEorOp5VvVhIDh2cZD2s1BtSdojGbhOTjAVbDhFKvKn793SlsMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753370899; c=relaxed/simple; bh=Sm/Zvebbu1bNwWT2jtlvN/rqsm/jqBuHeyrtvaK/OJk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=fI3WKXYPj++jeJoFdpgKCFG4P1JlaAqmG4gZ4VburzPRKytV8xPiKqoOYSKdgdVreFploc80amGnk6az+4gPiNnQCUhwERMoQY+QNbPnHUxsmVoeKM/mGp8Vpy+jz+0jZgwu4ZPKum3JDlOo+9Cp7pjut+jdai2z4YteNoCokVQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sRemamHC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sRemamHC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DE35C4CEF7; Thu, 24 Jul 2025 15:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1753370898; bh=Sm/Zvebbu1bNwWT2jtlvN/rqsm/jqBuHeyrtvaK/OJk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sRemamHCavmxiqkxiIpSQdeLtkQcomj/lJUyJSltGBqApqQdW9FQZGytGLdxzhZq5 1yqFeLAMj2oTonRHrszzvqB8nfjluRi0No8YDT1mqVzWtFWNVPo8TJsbqZixsD+HGt yS/+0Ul/5ZNnysMh33CIp6DCoikuwanXMrPjfxxAvoXpVIZ+h9+vOlBXI04mlwOPiF 3FW5sTQM5ZM65l+48C5fXc+yhmMndyS4itCsJkyzy1guWSzuEL5FYscOYFQoIJyRqx V1nVJy+sSKHrzNIIgr1eX4bCkKcXuBOLOO9MyQ/r3xUcI2Jmmt5p/vSq5J5VuSzrZC ZgWhFqpr3Zyhw== Date: Thu, 24 Jul 2025 16:28:10 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Gustavo Silva , Alex Lanzano , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Lothar Rubusch Subject: Re: [PATCH v4 3/3] iio: imu: bmi270: add support for motion events Message-ID: <20250724162810.214414fe@jic23-huawei> In-Reply-To: References: <20250711-bmi270-events-v4-0-53ec7da35046@gmail.com> <20250711-bmi270-events-v4-3-53ec7da35046@gmail.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 16 Jul 2025 12:49:28 +0300 Andy Shevchenko wrote: > On Tue, Jul 15, 2025 at 08:52:41PM -0300, Gustavo Silva wrote: > > On Tue, Jul 15, 2025 at 10:37:21AM +0300, Andy Shevchenko wrote: > > > On Fri, Jul 11, 2025 at 08:36:03PM -0300, Gustavo Silva wrote: > > ... > > > > Is this already documented in ABI? > > > > > Not yet. Should this have a device-specific ABI entry? > > I don't know, but what I can say is that change is no-go without documented ABI. > Indeed. Seems this particular combination has yet shown up (or we missed it for docs). Add appropriate events/in_accel_value_available entry to Documentation/ABI/sysfs-bus-iio Whilst you are there, good to check that all the other ABI for this device is listed in there. Given we mostly construct ABI from a bunch of parts, it is easy to miss entries for particular combinations of channel type and thing. Jonathan