From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Liya Huang <1425075683@qq.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/base/faux: Remove unnecessary match callback
Date: Thu, 24 Jul 2025 13:37:49 +0200 [thread overview]
Message-ID: <2025072430-spoilage-willing-6d5c@gregkh> (raw)
In-Reply-To: <tencent_5782606120514CBCC9339FD79EBC411FB607@qq.com>
On Thu, Jul 24, 2025 at 06:37:23PM +0800, Liya Huang wrote:
> The faux_match() function always returns 1, indicating a successful match.
> The driver core function driver_match_device() already handles this case
> by defaulting to 1 if the bus->match callback is NULL.
>
> The implementation in driver_match_device() is:
> return drv->bus->match ? drv->bus->match(dev, drv) : 1;
>
> Therefore, the faux_match() callback is redundant and can be removed to
> simplify the code, with no change in functionality.
>
> ---
> drivers/base/faux: Remove unnecessary match callback
>
> The faux_match() function always returns 1, indicating a successful match.
> The driver core function driver_match_device() already handles this case
> by defaulting to 1 if the bus->match callback is NULL.
>
> The implementation in driver_match_device() is:
> return drv->bus->match ? drv->bus->match(dev, drv) : 1;
>
> Therefore, the faux_match() callback is redundant and can be removed to
> simplify the code, with no change in functionality.
>
> Signed-off-by: Liya Huang <1425075683@qq.com>
> ---
> drivers/base/faux.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/base/faux.c b/drivers/base/faux.c
> index f5fbda0a9a44bd8e4831ee0ef9fc87841146d2da..005e4ecac05aebccb6fcf770f7e62848d9963c88 100644
> --- a/drivers/base/faux.c
> +++ b/drivers/base/faux.c
> @@ -33,12 +33,6 @@ static struct device faux_bus_root = {
> .init_name = "faux",
> };
>
> -static int faux_match(struct device *dev, const struct device_driver *drv)
> -{
> - /* Match always succeeds, we only have one driver */
> - return 1;
> -}
> -
> static int faux_probe(struct device *dev)
> {
> struct faux_object *faux_obj = to_faux_object(dev);
> @@ -77,7 +71,6 @@ static void faux_remove(struct device *dev)
>
> static const struct bus_type faux_bus_type = {
> .name = "faux",
> - .match = faux_match,
Let's leave this please, it makes things more "obvious" as to what is
going on and isn't hurting anything.
thanks,
greg k-h
prev parent reply other threads:[~2025-07-24 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 10:37 Liya Huang
2025-07-24 11:37 ` Greg Kroah-Hartman
2025-07-24 11:37 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025072430-spoilage-willing-6d5c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=1425075683@qq.com \
--cc=dakr@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®