From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67B1C2D4B57 for ; Fri, 25 Jul 2025 10:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753438097; cv=none; b=LdfMSRZkIvdIK9K+cyWluNP4N9wqBNzl1Deh2G/v6XTkxLGufBIDEq1Ql2c6vUtE8ZRqxGZ9o8AscgAp/n7bZnwhe91Q7FR+MxcWah581uUe1itqlW9Gr8/z31PcHtwW7ShmP6IYTYAIPo3kEfDXzNc97ZAacVWjEUyVOv/6Fno= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753438097; c=relaxed/simple; bh=IlswOXw/RTcT0slyrcVOlRkPyNua54MAWCCNfnpi6y0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=EhgxgH+SRQSuTC4qklvmwcoD/SkzHOCTVZBT19hvko0DzeTphTRgeah0v/s4/xjkIPJNnD/xu2y+5ds7cF1bmHjzlKJg1WdfUOEPaPKTvK8pjeLDucko1bfnM+g1dW1L2H5XbmN5UfCsp5cWeH2qtU6pDwzd2/PkojKZcNKoipM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CNJ504A+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CNJ504A+" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56P8vEdV026745 for ; Fri, 25 Jul 2025 10:08:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=6EBHc56iB4SgkIrGWkMoVed7ialO6Hu91Fg rEoulgGQ=; b=CNJ504A+r23mg0+9FgdE5QuAZ8FjXBbGOsVLU5VmGg8AfN4rxPl Dib+f/XqaltETQ27Rk97zohFGYJv3IBf6YA6vk8+ErR9zlOJ5ousaz/7FI+3by9T IKI6ayd6+9Byq6ARw8eKDeBxMyyrtFpjL7TDyF909e5SbjSCZ5LnjZPQAU/zVeT/ YnVdGaj4eJ80OCMRl7BnarG+z/TOzmsrBs/wEm4a6UVosISAt7ZoUY8XltPsvBXB 3RTu0NzigctUUhGR9DxyxnrQsjLlg6D/IeihOqMimddTMIWNsk5pOlc9sN4MVBUF LU8xpgCZNIsmKg4KPZlPrIGeM6ZVVG9CT0A== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 483w2u1nx6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 25 Jul 2025 10:08:14 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-236725af87fso31556635ad.3 for ; Fri, 25 Jul 2025 03:08:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753438093; x=1754042893; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6EBHc56iB4SgkIrGWkMoVed7ialO6Hu91FgrEoulgGQ=; b=JoN1Jm99NmF69jqAFixeEojg5BRVMq7aqjNUZ1G2VAxScyfWLWhLRRJSsgRMpnZTn0 OEcHm9yI8eOjiH0WETJ2n3WSk5kEJnni7s0QZ+QXeVMFZV79/+FRGCQcL6g/MT1zBkfs gMjcgfgsUAtgK9ru8jquw7Eo+d8UWPUzQqgqsdx+agf1C0uw4KcL3FpobY8m/baTtsMN aMxkriQnmV9HtL7+nJEpYAEVamL4TQmG6On8J/KkMzPTioXV0MqyWZ3cgkGuRWAY4Eik gz7+FXWHNUOHw8MFObSk3OMlToNWWnpx5fB1dxBu9JRwWYeis86oRie6ga3Cg8TicPdf VKjQ== X-Forwarded-Encrypted: i=1; AJvYcCUezaMSLeeAzmTIHRGWBC55NvuY4Re5+8HrIigyBSaK5cRp3Uj+vBEHI3KrXRb5n1guYYjn/pvmy9txCGI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7xt/RlHGvBCEGLcyWsDIO7XiIem8oJ0Aa3CuHLZ6vLgAP4y4R 3LwFdxJkKRyF350KIvMfJNUgCckOcG25D/GWLIKiU8EyuZh69fKgaXzP6V5zMV695OpV69efqX9 MBCbHHn5SOTj+E96zoOYQr0Ge0osmWDZrT8JTpknCfGqFlO+e7YOWMld+AARmT5HLD0w= X-Gm-Gg: ASbGncuXZFoGmf/SNv8zX1e++4rtl/qJ/OuomXSU0rZ9ErdnbM/G3yT4kA39o3KLL76 HMQyaaOSVg6i5s7kWXINFJIyuOMKqF47ayZTn8DubyVnOQXmS7oQt9goRnAhgqAp76ULWLrW7Qs mWZu3ZvtY1WaVqzbwnTgcfYMSeLJ0bcUKhH8s6i8n4I6BFgsdg8jgwRHcT/dfzhn0fHQT6ao3CF VBYEqDzVI9KSmPSJcQAKbcxUUkaaxssYA9Yvi4hx7CQDmKu8Zm3TqupEZ80XN3SOc1k9ckpfR7a /ouJhYpozFoAv7nSAg5f6qVXvS+XAkQYHk3U+X+eK5g+U4RQ/szVsezWiO6tz/3ss4/fQ/Sl9TL aCdJGOPdEos7fCvt+0to= X-Received: by 2002:a17:902:f68e:b0:234:8a16:d62b with SMTP id d9443c01a7336-23fb308080cmr22580795ad.12.1753438093415; Fri, 25 Jul 2025 03:08:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiwVDJYSX1y11czEmaF5LFxL17hgu0Lb2lAPb7Ue/TpYcJeCl2AQGCWJYInJsEyxe1YPp2QQ== X-Received: by 2002:a17:902:f68e:b0:234:8a16:d62b with SMTP id d9443c01a7336-23fb308080cmr22580135ad.12.1753438092796; Fri, 25 Jul 2025 03:08:12 -0700 (PDT) Received: from jiegan.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23fa48fd29dsm33641435ad.176.2025.07.25.03.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Jul 2025 03:08:12 -0700 (PDT) From: Jie Gan To: Suzuki K Poulose , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Alexander Shishkin , Tingwei Zhang , Jinlong Mao Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan Subject: [PATCH v4 00/10] coresight: ctcu: Enable byte-cntr function for TMC ETR Date: Fri, 25 Jul 2025 18:07:56 +0800 Message-Id: <20250725100806.1157-1-jie.gan@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI1MDA4NSBTYWx0ZWRfX5d9A3QO7BiSd N8ci7EKJvrWa/DYho4cSAMadS7XLFSyyzqDPC7Z5qwY5m//alkNF2KgTZE7cQDH0zvikkcVX2Im 7RjlK0J+TYc1pgNMTrRzawMqTP/lYdBoW6HKZiHksXYUJzAODdrLfeabT5CywCcaFObTo3wV02c JUbuu7UOcdcAf+t2epatlggXCqr0UKtVs6GVPRSbyNzzSgzvximuoN8I7rgFmcR7LL4zLaybQ7o YmwDuNdM1gIB6xek3Rhrysmg3r5X/7CcWhE6lhST7G7QGKTU+Vki1gH8rN8KzDggxlSKoVd8a/o NQRDwA8Nz9f96tH2J9JFbYslKfXfpkzu/eZfviJ1RyiE0ZsxPG655j16k4xMlX1dS6p9UBOoYut j1VU7D8TNairXC4+HD905s3zSMEN9ijEC3DT7Ip5/G3XiXno0KTLtOZUhJzkVXQmCCzmWMfd X-Proofpoint-ORIG-GUID: AkjpwdC2_DHpfp3VWV8I1kMzyzzBI57_ X-Authority-Analysis: v=2.4 cv=FcA3xI+6 c=1 sm=1 tr=0 ts=6883578e cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=Wb1JkmetP80A:10 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=URa5TLP9FqKrhjsjdTUA:9 a=uG9DUKGECoFWVXl0Dc02:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: AkjpwdC2_DHpfp3VWV8I1kMzyzzBI57_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-25_02,2025-07-24_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 bulkscore=0 adultscore=0 suspectscore=0 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=999 clxscore=1015 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507250085 The byte-cntr function provided by the CTCU device is used to count the trace data entering the ETR. An interrupt is triggered if the data size exceeds the threshold set in the BYTECNTRVAL register. The interrupt handler counts the number of triggered interruptions. Based on this concept, the irq_cnt can be used to determine whether the etr_buf is full. The ETR device will be disabled when the active etr_buf is nearly full or a timeout occurs. The nearly full buffer will be switched to background after synced. A new buffer will be picked from the etr_buf_list, then restart the ETR device. The byte-cntr reading functions can access data from the synced and deactivated buffer, transferring trace data from the etr_buf to userspace without stopping the ETR device. The byte-cntr read operation has integrated with the file node tmc_etr, for example: /dev/tmc_etr0 /dev/tmc_etr1 There are two scenarios for the tmc_etr file node with byte-cntr function: 1. BYTECNTRVAL register is configured and byte-cntr is enabled -> byte-cntr read 2. BYTECNTRVAL register is reset or byte-cntr is disabled -> original behavior Shell commands to enable byte-cntr reading for etr0: echo 0x10000 > /sys/bus/coresight/devices/ctcu0/irq_threshold echo 1 > /sys/bus/coresight/devices/tmc_etr0/enable_sink echo 1 > /sys/bus/coresight/devices/etm0/enable_source cat /dev/tmc_etr0 Enable both ETR0 and ETR1: echo 0x10000 0x10000 > /sys/bus/coresight/devices/ctcu0/irq_threshold Reset the BYTECNTR register for etr0: echo 0 > /sys/bus/coresight/devices/ctcu0/irq_threshold Changes in V4: 1. Rename the function to coresight_get_in_port_dest regarding to Mike's comment (patch 1/10). 2. Add lock to protect the connections regarding to Mike's comment (patch 2/10). 3. Move all byte-cntr functions to coresight-ctcu-byte-cntr file. 4. Add tmc_read_ops to wrap all read operations for TMC device. 5. Add a function in helper_ops to check whether the byte-cntr is enabkled. 6. Call byte-cntr's read_ops if byte-cntr is enabled when reading data from the sysfs node. Link to V3 resend - https://lore.kernel.org/all/20250714063109.591-1-jie.gan@oss.qualcomm.com/ Changes in V3 resend: 1. rebased on next-20250711. Link to V3 - https://lore.kernel.org/all/20250624060438.7469-1-jie.gan@oss.qualcomm.com/ Changes in V3: 1. The previous solution has been deprecated. 2. Add a etr_buf_list to manage allcated etr buffers. 3. Add a logic to switch buffer for ETR. 4. Add read functions to read trace data from synced etr buffer. Link to V2 - https://lore.kernel.org/all/20250410013330.3609482-1-jie.gan@oss.qualcomm.com/ Changes in V2: 1. Removed the independent file node /dev/byte_cntr. 2. Integrated the byte-cntr's file operations with current ETR file node. 3. Optimized the driver code of the CTCU that associated with byte-cntr. 4. Add kernel document for the export API tmc_etr_get_rwp_offset. 5. Optimized the way to read the rwp_offset according to Mike's suggestion. 6. Removed the dependency of the dts patch. Link to V1 - https://lore.kernel.org/all/20250310090407.2069489-1-quic_jiegan@quicinc.com/ Jie Gan (10): coresight: core: Refactoring ctcu_get_active_port and make it generic coresight: core: add a new API to retrieve the helper device coresight: tmc: add etr_buf_list to store allocated etr_buf coresight: tmc: add create/delete functions for etr_buf_node coresight: tmc: Introduce tmc_read_ops to wrap read operations dt-bindings: arm: add an interrupt property for Coresight CTCU coresight: ctcu: enable byte-cntr for TMC ETR devices coresight: add a new function in helper_ops coresight: tmc: integrate byte-cntr's read_ops with sysfs file_ops arm64: dts: qcom: sa8775p: Add interrupts to CTCU device .../testing/sysfs-bus-coresight-devices-ctcu | 5 + .../bindings/arm/qcom,coresight-ctcu.yaml | 17 + arch/arm64/boot/dts/qcom/sa8775p.dtsi | 5 + drivers/hwtracing/coresight/Makefile | 2 +- drivers/hwtracing/coresight/coresight-core.c | 59 +++ .../coresight/coresight-ctcu-byte-cntr.c | 364 ++++++++++++++++++ .../hwtracing/coresight/coresight-ctcu-core.c | 148 +++++-- drivers/hwtracing/coresight/coresight-ctcu.h | 60 ++- drivers/hwtracing/coresight/coresight-priv.h | 4 + .../hwtracing/coresight/coresight-tmc-core.c | 99 +++-- .../hwtracing/coresight/coresight-tmc-etr.c | 81 ++++ drivers/hwtracing/coresight/coresight-tmc.h | 40 ++ include/linux/coresight.h | 3 + 13 files changed, 828 insertions(+), 59 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-ctcu create mode 100644 drivers/hwtracing/coresight/coresight-ctcu-byte-cntr.c -- 2.34.1