From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Salah Triki <salah.triki@gmail.com>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Pali Rohár" <pali@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: mvebu: Use devm_add_action_or_reset()
Date: Fri, 25 Jul 2025 11:13:27 +0100 [thread overview]
Message-ID: <20250725111327.0000346f@huawei.com> (raw)
In-Reply-To: <aIMAkbdOyHsiPeph@pc>
On Fri, 25 Jul 2025 04:57:05 +0100
Salah Triki <salah.triki@gmail.com> wrote:
> On Thu, Jul 24, 2025 at 11:42:17AM -0500, Bjorn Helgaas wrote:
> > On Sat, Jul 19, 2025 at 05:34:40AM +0100, Salah Triki wrote:
> >
> > ret = devm_add_action_or_reset(dev, clk_put, port->clk)
> >
> The second argument of devm_add_action_or_reset() is of type void (*)(void *)
> and the argument of clk_put() is of type struct clk *, so I think a cast is
> needed:
>
> ret = devm_add_action_or_reset(dev, (void (*)(void *)) clk_put, port->clk)
Can you use devm_get_clk_from_child() here? If not add a similar variant.
>
> Best regards,
> Salah Triki
>
prev parent reply other threads:[~2025-07-25 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-19 4:34 Salah Triki
2025-07-23 16:40 ` Manivannan Sadhasivam
2025-07-24 16:42 ` Bjorn Helgaas
2025-07-25 3:57 ` Salah Triki
2025-07-25 10:13 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725111327.0000346f@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=salah.triki@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®