From: Simon Horman <horms@kernel.org>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Sunil Goutham <sgoutham@marvell.com>,
Geetha sowjanya <gakula@marvell.com>,
Subbaraya Sundeep <sbhatta@marvell.com>,
Bharat Bhushan <bbhushan2@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [net-next PatchV3] Octeontx2-pf: ethtool: Display "Autoneg" and "Port" fields
Date: Fri, 25 Jul 2025 14:13:15 +0100 [thread overview]
Message-ID: <20250725131314.GD1367887@horms.kernel.org> (raw)
In-Reply-To: <20250724101057.2419425-1-hkelam@marvell.com>
On Thu, Jul 24, 2025 at 03:40:57PM +0530, Hariprasad Kelam wrote:
> The Octeontx2/CN10k netdev drivers access a shared firmware structure
> to obtain link configuration details, such as supported and advertised
> link modes. This patch adds support to display the same.
>
> ethtool eth1
> Settings for eth1:
> Supported ports: [ ]
> Supported link modes: 10000baseCR/Full
> 10000baseSR/Full
> 10000baseLR/Full
> Supported pause frame use: No
> Supports auto-negotiation: Yes
> Supported FEC modes: None
> Advertised link modes: Not reported
> Advertised pause frame use: No
> Advertised auto-negotiation: Yes
> Advertised FEC modes: None
> Speed: 10000Mb/s
> Duplex: Full
> Port: Twisted Pair
> PHYAD: 0
> Transceiver: internal
> Auto-negotiation: on
> MDI-X: Unknown
> Current message level: 0x00000000 (0)
> Link detected: yes
>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> ---
> V3 * Fix port types in firmware
>
> V2 * Add validation for 'port' parameter
> include full output of ethtool ethx
Thanks, I believe this addresses Jakub's review of v2.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-07-25 13:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 10:10 Hariprasad Kelam
2025-07-25 13:13 ` Simon Horman [this message]
2025-07-25 23:53 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725131314.GD1367887@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=bbhushan2@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®