From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Ian Rogers <irogers@google.com>,
Kan Liang <kan.liang@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-perf-users@vger.kernel.org
Subject: [PATCH v4 6/9] perf annotate: Add 'T' hot key to toggle data type display
Date: Fri, 25 Jul 2025 12:37:52 -0700 [thread overview]
Message-ID: <20250725193755.12276-7-namhyung@kernel.org> (raw)
In-Reply-To: <20250725193755.12276-1-namhyung@kernel.org>
Support data type display with a key press so that users can toggle the
output dynamically on TUI. Also display "[Type]" in the title line if
it's enabled.
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/ui/browsers/annotate.c | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index cdee1969f3131a7c..4b059e0bafd33fcf 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -525,9 +525,10 @@ static void ui_browser__init_asm_mode(struct ui_browser *browser)
static int sym_title(struct symbol *sym, struct map *map, char *title,
size_t sz, int percent_type)
{
- return snprintf(title, sz, "%s %s [Percent: %s]", sym->name,
+ return snprintf(title, sz, "%s %s [Percent: %s] %s", sym->name,
dso__long_name(map__dso(map)),
- percent_type_str(percent_type));
+ percent_type_str(percent_type),
+ annotate_opts.code_with_type ? "[Type]" : "");
}
/*
@@ -901,7 +902,8 @@ static int annotate_browser__run(struct annotate_browser *browser,
"b Toggle percent base [period/hits]\n"
"B Branch counter abbr list (Optional)\n"
"? Search string backwards\n"
- "f Toggle showing offsets to full address\n");
+ "f Toggle showing offsets to full address\n"
+ "T Toggle data type display\n");
continue;
case 'r':
script_browse(NULL, NULL);
@@ -1021,6 +1023,12 @@ static int annotate_browser__run(struct annotate_browser *browser,
case 'f':
annotation__toggle_full_addr(notes, ms);
continue;
+ case 'T':
+ annotate_opts.code_with_type ^= 1;
+ if (browser->dbg == NULL)
+ browser->dbg = debuginfo__new(dso__long_name(map__dso(ms->map)));
+ annotate_browser__show(&browser->b, title, help);
+ continue;
case K_LEFT:
case '<':
case '>':
@@ -1115,8 +1123,7 @@ int __hist_entry__tui_annotate(struct hist_entry *he, struct map_symbol *ms,
ret = annotate_browser__run(&browser, evsel, hbt);
- if (annotate_opts.code_with_type)
- debuginfo__delete(browser.dbg);
+ debuginfo__delete(browser.dbg);
if (not_annotated && !notes->src->tried_source)
annotated_source__purge(notes->src);
--
2.50.1
next prev parent reply other threads:[~2025-07-25 19:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 19:37 [PATCHSET v4 0/9] perf annotate: Support --code-with-type on TUI Namhyung Kim
2025-07-25 19:37 ` [PATCH v4 1/9] perf annotate: Rename to __hist_entry__tui_annotate() Namhyung Kim
2025-07-26 0:16 ` Ian Rogers
2025-07-28 18:39 ` Namhyung Kim
2025-07-25 19:37 ` [PATCH v4 2/9] perf annotate: Remove __annotation_line__write() Namhyung Kim
2025-07-26 0:20 ` Ian Rogers
2025-07-28 18:42 ` Namhyung Kim
2025-07-25 19:37 ` [PATCH v4 3/9] perf annotate: Pass annotation_print_data to annotation_line__write() Namhyung Kim
2025-07-26 0:23 ` Ian Rogers
2025-07-28 18:44 ` Namhyung Kim
2025-07-25 19:37 ` [PATCH v4 4/9] perf annotate: Simplify width calculation in annotation_line__write() Namhyung Kim
2025-07-26 0:30 ` Ian Rogers
2025-07-28 18:47 ` Namhyung Kim
2025-07-25 19:37 ` [PATCH v4 5/9] perf annotate: Add --code-with-type support for TUI Namhyung Kim
2025-07-26 0:31 ` Ian Rogers
2025-07-28 18:47 ` Namhyung Kim
2025-07-25 19:37 ` Namhyung Kim [this message]
2025-07-26 0:34 ` [PATCH v4 6/9] perf annotate: Add 'T' hot key to toggle data type display Ian Rogers
2025-07-25 19:37 ` [PATCH v4 7/9] perf annotate: Show warning when debuginfo is not available Namhyung Kim
2025-07-26 0:38 ` Ian Rogers
2025-07-25 19:37 ` [PATCH v4 8/9] perf annotate: Hide data-type for stack operation and canary Namhyung Kim
2025-07-26 0:44 ` Ian Rogers
2025-07-28 18:51 ` Namhyung Kim
2025-07-25 19:37 ` [PATCH v4 9/9] perf annotate: Add dso__debuginfo() helper Namhyung Kim
2025-07-26 0:46 ` Ian Rogers
2025-07-28 18:54 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725193755.12276-7-namhyung@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®