mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Frank Li <Frank.Li@nxp.com>,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] dt-bindings: mmc: fsl,esdhc: Add explicit reference to mmc-controller-common
Date: Fri, 25 Jul 2025 18:35:54 -0500	[thread overview]
Message-ID: <20250725233554.GA2028042-robh@kernel.org> (raw)
In-Reply-To: <20250725060152.262094-1-alexander.stein@ew.tq-group.com>

On Fri, Jul 25, 2025 at 08:01:51AM +0200, Alexander Stein wrote:
> Even though it is referenced by mmc/mmc-controller.yaml it still raises
> the warning:
>   esdhc@1560000 (fsl,ls1021a-esdhc): Unevaluated properties are not allowed ('bus-width' was unexpected)
> 
> Adding an explicit reference fixes this.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> I don't know if this is a tooling problem or whatever. I would have
> expected that mmc-controller-common.yaml is added via
> mmc-controller.yaml. But apparently this is missing resulting in the
> given warning. Hence adding the reference

The issue is the nodename. Since validation of it fails, the whole 
referenced schema is not 'evaluated' and bus-width is unevaluated. Best 
I can tell, that's correct behavior for json-schema.

I guess this is an adequate work-around.

Acked-by: Rob Herring (Arm) <robh@kernel.org>

> 
>  Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> index 62087cf920df8..f45e592901e24 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> @@ -90,6 +90,7 @@ required:
>  
>  allOf:
>    - $ref: sdhci-common.yaml#
> +  - $ref: mmc-controller-common.yaml#
>  
>  unevaluatedProperties: false
>  
> -- 
> 2.43.0
> 

  reply	other threads:[~2025-07-25 23:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25  6:01 Alexander Stein
2025-07-25 23:35 ` Rob Herring [this message]
2025-08-18 10:54 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250725233554.GA2028042-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®