From: <changqing.li@windriver.com>
To: <namhyung@kernel.org>, <james.clark@linaro.org>,
<irogers@google.com>, <charlie@rivosinc.com>,
<linux-kernel@vger.kernel.org>
Cc: <changqing.li@windriver.com>
Subject: [PATCH] tools/build: make in-target rule robust against too long argument error
Date: Mon, 28 Jul 2025 17:31:53 +0800 [thread overview]
Message-ID: <20250728093153.2330009-1-changqing.li@windriver.com> (raw)
From: Changqing Li <changqing.li@windriver.com>
The command length of in-target scales with the depth of the directory
times the number of objects in the Makefile. When there are many
objects, and O=[absolute_path] is set, and the absolute_path is
relatively long. It is possile that this line "$(call
if_changed,$(host)ld_multi)" will report error:
"make[4]: /bin/sh: Argument list too long"
For example, build perf tools with O=/long/output/path
Like built-in.a and *.mod rules in scripts/Makefile.build, add
$(objpredix)/ by the shell command instead of by Make's builtin
function.
Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
tools/build/Makefile.build | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
index 3584ff308607..39066a3ef2fc 100644
--- a/tools/build/Makefile.build
+++ b/tools/build/Makefile.build
@@ -70,11 +70,13 @@ quiet_cmd_gen = GEN $@
# If there's nothing to link, create empty $@ object.
quiet_cmd_ld_multi = LD $@
cmd_ld_multi = $(if $(strip $(obj-y)),\
- $(LD) -r -o $@ $(filter $(obj-y),$^),rm -f $@; $(AR) rcs $@)
+ printf "$(objprefix)%s " $(patsubst $(objprefix)%,%,$(filter $(obj-y),$^)) | \
+ xargs $(LD) -r -o $@,rm -f $@; $(AR) rcs $@)
quiet_cmd_host_ld_multi = HOSTLD $@
cmd_host_ld_multi = $(if $(strip $(obj-y)),\
- $(HOSTLD) -r -o $@ $(filter $(obj-y),$^),rm -f $@; $(HOSTAR) rcs $@)
+ printf "$(objprefix)%s " $(patsubst $(objprefix)%,%,$(filter $(obj-y),$^)) | \
+ xargs $(HOSTLD) -r -o $@,rm -f $@; $(HOSTAR) rcs $@)
ifneq ($(filter $(obj),$(hostprogs)),)
host = host_
--
2.34.1
next reply other threads:[~2025-07-28 9:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 9:31 changqing.li [this message]
2025-08-18 20:38 ` Ian Rogers
2025-08-19 3:01 ` Changqing Li
2025-10-28 2:15 ` Changqing Li
2026-03-03 22:33 ` Ian Rogers
2026-03-04 2:35 ` Changqing Li
2026-03-04 14:13 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250728093153.2330009-1-changqing.li@windriver.com \
--to=changqing.li@windriver.com \
--cc=charlie@rivosinc.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®