From: Dishank Jogi <jogidishank503@gmail.com>
To: geert@linux-m68k.org
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
darshanrathod475@gmail.com,
Dishank Jogi <jogidishank503@gmail.com>
Subject: [PATCH] zorro: fix checkpatch error by avoiding assignment in if-statement.
Date: Mon, 28 Jul 2025 09:34:12 +0000 [thread overview]
Message-ID: <20250728093412.48065-1-jogidishank503@gmail.com> (raw)
These changes improve code readability and bring the file
in line with the Linux kernel coding style.
No functional changes.
Signed-off-by: Dishank Jogi <jogidishank503@gmail.com>
---
drivers/zorro/gen-devlist.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/zorro/gen-devlist.c b/drivers/zorro/gen-devlist.c
index e325c5ce995b..ff4515e02409 100644
--- a/drivers/zorro/gen-devlist.c
+++ b/drivers/zorro/gen-devlist.c
@@ -44,7 +44,8 @@ main(void)
while (fgets(line, sizeof(line)-1, stdin)) {
lino++;
- if ((c = strchr(line, '\n')))
+ c = strchr(line, '\n')
+ if (c)
*c = 0;
if (!line[0] || line[0] == '#')
continue;
@@ -68,7 +69,8 @@ main(void)
fprintf(devf, "\tPRODUCT(%s,%s,\"", manuf, line+1);
pq(devf, c);
fputs("\")\n", devf);
- } else goto err;
+ } else
+ goto err;
break;
default:
goto err;
--
2.43.0
next reply other threads:[~2025-07-28 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 9:34 Dishank Jogi [this message]
2025-07-28 20:42 ` Christophe JAILLET
2025-07-29 7:08 ` Geert Uytterhoeven
2025-07-29 12:10 ` Jogi Dishank
2025-07-29 15:49 ` Geert Uytterhoeven
2025-07-29 15:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250728093412.48065-1-jogidishank503@gmail.com \
--to=jogidishank503@gmail.com \
--cc=darshanrathod475@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®