From: Nikolay Borisov <nik.borisov@suse.com>
To: linux-security-module@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, paul@paul-moore.com,
serge@hallyn.com, jmorris@namei.org, dan.j.williams@intel.com,
Nikolay Borisov <nik.borisov@suse.com>
Subject: [PATCH v2 3/3] lockdown: Use snprintf in lockdown_read
Date: Mon, 28 Jul 2025 14:15:17 +0300 [thread overview]
Message-ID: <20250728111517.134116-4-nik.borisov@suse.com> (raw)
In-Reply-To: <20250728111517.134116-1-nik.borisov@suse.com>
Since individual features are now locked down separately ensure that if
the printing code is change to list them a buffer overrun won't be
introduced. As per Serge's recommendation switch from using sprintf to
using snprintf and return EINVAL in case longer than 80 char string hasi
to be printed.
Signed-off-by: Nikolay Borisov <nik.borisov@suse.com>
---
security/lockdown/lockdown.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/security/lockdown/lockdown.c b/security/lockdown/lockdown.c
index 412184121279..ed1dde41d7d3 100644
--- a/security/lockdown/lockdown.c
+++ b/security/lockdown/lockdown.c
@@ -112,11 +112,19 @@ static ssize_t lockdown_read(struct file *filp, char __user *buf, size_t count,
if (lockdown_reasons[level]) {
const char *label = lockdown_reasons[level];
+ int ret = 0;
+ int write_len = 80-offset;
+
if (test_bit(level, kernel_locked_down))
- offset += sprintf(temp+offset, "[%s] ", label);
+ ret = snprintf(temp+offset, write_len, "[%s] ", label);
else
- offset += sprintf(temp+offset, "%s ", label);
+ ret = snprintf(temp+offset, write_len, "%s ", label);
+
+ if (ret < 0 || ret >= write_len)
+ return -ENOMEM;
+
+ offset += ret;
}
}
--
2.34.1
next prev parent reply other threads:[~2025-07-28 11:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 11:15 [PATCH v2 0/3] Allow individual features to be locked down Nikolay Borisov
2025-07-28 11:15 ` [PATCH v2 1/3] lockdown: Switch implementation to using bitmap Nikolay Borisov
2025-07-28 12:47 ` Serge E. Hallyn
2025-07-28 13:21 ` Serge E. Hallyn
2025-08-05 22:18 ` dan.j.williams
2025-07-28 11:15 ` [PATCH v2 2/3] lockdown/kunit: Introduce kunit tests Nikolay Borisov
2025-07-28 12:49 ` Serge E. Hallyn
2025-07-28 22:04 ` kernel test robot
2025-07-29 7:46 ` Nikolay Borisov
2025-07-29 23:28 ` Philip Li
2025-07-29 7:30 ` kernel test robot
2025-07-28 11:15 ` Nikolay Borisov [this message]
2025-07-28 12:39 ` [PATCH v2 3/3] lockdown: Use snprintf in lockdown_read Serge E. Hallyn
2025-08-05 7:56 ` Nikolay Borisov
2025-08-05 22:30 ` dan.j.williams
2025-07-29 12:16 ` [PATCH v2 0/3] Allow individual features to be locked down Nicolas Bouchinet
2025-07-29 12:25 ` Nikolay Borisov
2025-08-05 6:57 ` xiujianfeng
2025-08-05 8:03 ` Nikolay Borisov
2025-08-05 23:28 ` dan.j.williams
2025-08-14 8:59 ` Nicolas Bouchinet
2025-08-14 10:02 ` Nikolay Borisov
2025-08-14 10:51 ` Nicolas Bouchinet
2025-08-05 23:43 ` dan.j.williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250728111517.134116-4-nik.borisov@suse.com \
--to=nik.borisov@suse.com \
--cc=dan.j.williams@intel.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®