mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@kernel.org>
To: Jens Remus <jremus@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	bpf@vger.kernel.org, x86@kernel.org,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Andrii Nakryiko <andrii@kernel.org>,
	Indu Bhagat <indu.bhagat@oracle.com>,
	"Jose E. Marchesi" <jemarch@gnu.org>,
	Beau Belgrave <beaub@linux.microsoft.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Jens Axboe <axboe@kernel.dk>, Florian Weimer <fweimer@redhat.com>,
	Sam James <sam@gentoo.org>
Subject: Re: [PATCH v15 01/10] unwind_user: Add user space unwinding API with frame pointer support
Date: Mon, 28 Jul 2025 12:08:47 -0400	[thread overview]
Message-ID: <20250728120847.0fd1c190@batman.local.home> (raw)
In-Reply-To: <5fb8ada0-d90c-4a58-a38d-97b3d0787554@linux.ibm.com>

On Mon, 28 Jul 2025 17:24:52 +0200
Jens Remus <jremus@linux.ibm.com> wrote:

> 
> Reviewed-by: Jens Remus <jremus@linux.ibm.com>

Thanks.

> 
> > diff --git a/kernel/unwind/user.c b/kernel/unwind/user.c  
> 
> > +static int unwind_user_next_fp(struct unwind_user_state *state)
> > +{
> > +	struct unwind_user_frame *frame = &fp_frame;  
> 
> Optional: Pointer to const?

Hmm, yeah, and we can easily make fp_frame a constant as it's only
updated by the arch macro and never modified.

> 
> > +	unsigned long cfa, fp, ra = 0;  
> 
> Nit: Is initialization of ra really required?  I don't see where ra
> would be getting used without being set beforehand.

That's probably leftover.

These are minor changes, I'll update.

Thanks for the review.

-- Steve

  reply	other threads:[~2025-07-28 16:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-25 18:55 [PATCH v15 00/10] unwind_user: Deferred unwinding infrastructure Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 01/10] unwind_user: Add user space unwinding API with frame pointer support Steven Rostedt
2025-07-28 15:24   ` Jens Remus
2025-07-28 16:08     ` Steven Rostedt [this message]
2025-07-25 18:55 ` [PATCH v15 02/10] unwind_user/deferred: Add unwind_user_faultable() Steven Rostedt
2025-07-28 15:29   ` Jens Remus
2025-07-25 18:55 ` [PATCH v15 03/10] unwind_user/deferred: Add unwind cache Steven Rostedt
2025-07-28 15:46   ` Jens Remus
2025-07-28 16:15     ` Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 04/10] unwind_user/deferred: Add deferred unwinding interface Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 05/10] unwind_user/deferred: Make unwind deferral requests NMI-safe Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 06/10] unwind deferred: Use bitmask to determine which callbacks to call Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 07/10] unwind deferred: Add unwind_completed mask to stop spurious callbacks Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 08/10] unwind: Add USED bit to only have one conditional on way back to user space Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 09/10] unwind deferred: Use SRCU unwind_deferred_task_work() Steven Rostedt
2025-07-25 18:55 ` [PATCH v15 10/10] unwind: Finish up unwind when a task exits Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250728120847.0fd1c190@batman.local.home \
    --to=rostedt@kernel.org \
    --cc=acme@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=andrii@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=beaub@linux.microsoft.com \
    --cc=bpf@vger.kernel.org \
    --cc=fweimer@redhat.com \
    --cc=indu.bhagat@oracle.com \
    --cc=jemarch@gnu.org \
    --cc=jolsa@kernel.org \
    --cc=jpoimboe@kernel.org \
    --cc=jremus@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=sam@gentoo.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®