From: Frank Li <Frank.Li@nxp.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Rui Miguel Silva <rmfrfs@gmail.com>,
Martin Kepplinger <martink@posteo.de>,
Purism Kernel Team <kernel@puri.sm>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-media@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Frank Li <Frank.Li@nxp.com>
Subject: [PATCH v4 2/5] media: v4l2-common: Add helper function v4l_get_required_align_by_bpp()
Date: Tue, 29 Jul 2025 12:06:23 -0400 [thread overview]
Message-ID: <20250729-imx8qxp_pcam-v4-2-4dfca4ed2f87@nxp.com> (raw)
In-Reply-To: <20250729-imx8qxp_pcam-v4-0-4dfca4ed2f87@nxp.com>
Add helper v4l_get_required_align_by_bpp() to help get width alignment
requirement. Basic replace below logic and enhance to any 2^[0..31] in
drivers/media/platform/nxp/imx-mipi-csis.c
mipi_csis_set_fmt(
{
...
switch (csis_fmt->width % 8) {
case 0:
align = 0;
break;
case 4:
align = 1;
break;
case 2:
case 6:
align = 2;
break;
default:
/* 1, 3, 5, 7 */
align = 3;
break;
}
...
}
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
changes in v4
- new patch
---
include/media/v4l2-common.h | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
index 0a43f56578bce1896cf63e29dd19f58ec0c46bed..a861d83bcd835dc854476b25919383415e5d434f 100644
--- a/include/media/v4l2-common.h
+++ b/include/media/v4l2-common.h
@@ -669,4 +669,34 @@ static inline bool v4l2_is_quant_valid(__u8 quantization)
quantization == V4L2_QUANTIZATION_LIM_RANGE;
}
+/**
+ * v4l_get_required_align_by_bpp - get align requirement for
+ * v4l_bound_align_image(). (bpp * width) % (1 << align) have to be 0.
+ * given number bpp, get width's alignment requirement. For example,
+ * if align is 3, means require bpp * width must be multiples of 8.
+ * bpp return width's requirememnt
+ * 0 0 none
+ * 1 3 8 (need 3 zero bits)
+ * 2 2 4
+ * 3 3 8
+ * 4 1 2
+ * 5 3 8
+ * 6 2 4
+ * 7 3 8
+ * @bpp: input bpp
+ * @align: expected alignment, 2^(align).
+ *
+ * return: required alignment.
+ */
+static inline u32 v4l_get_required_align_by_bpp(u32 bpp, u32 align)
+{
+ int pos;
+
+ if (bpp == 0)
+ return 0;
+
+ pos = ffs(bpp) - 1;
+ return pos > align ? 0 : align - pos;
+}
+
#endif /* V4L2_COMMON_H_ */
--
2.34.1
next prev parent reply other threads:[~2025-07-29 16:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 16:06 [PATCH v4 0/5] media: imx8qxp: add parallel camera support Frank Li
2025-07-29 16:06 ` [PATCH v4 1/5] dt-bindings: media: add i.MX parallel CPI support Frank Li
2025-07-29 16:06 ` Frank Li [this message]
2025-07-29 16:06 ` [PATCH v4 3/5] media: nxp: add V4L2 subdev driver for camera parallel interface (CPI) Frank Li
2025-07-29 16:06 ` [PATCH v4 4/5] arm64: dts: imx8: add camera parallel interface (CPI) node Frank Li
2025-07-29 16:06 ` [PATCH v4 5/5] arm64: dts: imx8qxp-mek: add parallel ov5640 camera support Frank Li
2025-08-05 1:08 ` [PATCH v4 0/5] media: imx8qxp: add parallel " Laurent Pinchart
2025-09-02 12:01 ` Frank Li
2025-09-02 12:39 ` Laurent Pinchart
2025-09-03 13:56 ` Frank Li
2025-11-05 17:03 ` Frank Li
2025-11-05 17:19 ` Laurent Pinchart
2025-11-05 19:31 ` Frank Li
2025-11-06 10:34 ` Rui Miguel Silva
2025-11-06 15:58 ` Frank Li
2025-12-02 20:36 ` Frank Li
2025-12-03 12:19 ` Rui Miguel Silva
2025-12-03 21:01 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250729-imx8qxp_pcam-v4-2-4dfca4ed2f87@nxp.com \
--to=frank.li@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rmfrfs@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®