From: Darshan Rathod <darshanrathod475@gmail.com>
To: gregkh@linuxfoundation.org, m.grzeschik@pengutronix.de
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Darshan Rathod <darshanrathod475@gmail.com>
Subject: [PATCH v2] usb: gadget: uvc: avoid assignment in if conditions
Date: Wed, 30 Jul 2025 09:04:11 +0000 [thread overview]
Message-ID: <20250730090411.13044-1-darshanrathod475@gmail.com> (raw)
Refactored code to separate assignments from conditional checks.
This improves readability and conforms to kernel coding style
as reported by checkpatch.pl.
Signed-off-by: Darshan Rathod <darshanrathod475@gmail.com>
---
drivers/usb/gadget/function/uvc_video.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c
index fb77b0b21790..d77ee5fd9b21 100644
--- a/drivers/usb/gadget/function/uvc_video.c
+++ b/drivers/usb/gadget/function/uvc_video.c
@@ -777,18 +777,21 @@ int uvcg_video_enable(struct uvc_video *video)
*/
video->is_enabled = true;
- if ((ret = uvcg_queue_enable(&video->queue, 1)) < 0)
+ ret = uvcg_queue_enable(&video->queue, 1);
+ if (ret < 0)
return ret;
- if ((ret = uvc_video_alloc_requests(video)) < 0)
+ ret = uvc_video_alloc_requests(video);
+ if (ret < 0)
return ret;
if (video->max_payload_size) {
video->encode = uvc_video_encode_bulk;
video->payload_size = 0;
- } else
+ } else {
video->encode = video->queue.use_sg ?
uvc_video_encode_isoc_sg : uvc_video_encode_isoc;
+ }
video->req_int_count = 0;
--
2.43.0
next reply other threads:[~2025-07-30 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 9:04 Darshan Rathod [this message]
2025-07-30 11:28 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730090411.13044-1-darshanrathod475@gmail.com \
--to=darshanrathod475@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®