From: Philipp Zabel <philipp.zabel@gmail.com>
To: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Philipp Zabel <p.zabel@pengutronix.de>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: [PATCH RFC 1/6] drm/amdgpu: don't wake up the GPU for some IOCTLs
Date: Thu, 31 Jul 2025 07:36:34 +0200 [thread overview]
Message-ID: <20250731-b4-dont-wake-next-v1-1-e51bdc347fa3@gmail.com> (raw)
In-Reply-To: <20250731-b4-dont-wake-next-v1-0-e51bdc347fa3@gmail.com>
From: Alex Deucher <alexander.deucher@amd.com>
Don't wake the GPU if the IOCTL doesn't need to power
up the GPU.
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2295
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Tested-by: Philipp Zabel <philipp.zabel@gmail.com>
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 60 ++++++++++++++++++++++++++++++---
1 file changed, 55 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 3bb9b25cd1219..34b9d63a86227 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -2926,23 +2926,73 @@ static int amdgpu_drm_release(struct inode *inode, struct file *filp)
return drm_release(inode, filp);
}
+static const unsigned int no_wake_ioctl_list[] = {
+ DRM_IOCTL_VERSION,
+ DRM_IOCTL_GET_UNIQUE,
+ DRM_IOCTL_GET_MAGIC,
+ DRM_IOCTL_GET_CLIENT,
+ DRM_IOCTL_GET_STATS,
+ DRM_IOCTL_GET_CAP,
+ DRM_IOCTL_SET_CLIENT_CAP,
+ DRM_IOCTL_SET_VERSION,
+ DRM_IOCTL_SET_UNIQUE,
+ DRM_IOCTL_BLOCK,
+ DRM_IOCTL_UNBLOCK,
+ DRM_IOCTL_AUTH_MAGIC,
+ DRM_IOCTL_SET_MASTER,
+ DRM_IOCTL_ADD_DRAW,
+ DRM_IOCTL_RM_DRAW,
+ DRM_IOCTL_FINISH,
+ DRM_IOCTL_UPDATE_DRAW,
+ DRM_IOCTL_MODE_GETRESOURCES,
+ DRM_IOCTL_MODE_GETPLANERESOURCES,
+ DRM_IOCTL_MODE_GETCRTC,
+ DRM_IOCTL_MODE_GETPLANE,
+ DRM_IOCTL_MODE_GETGAMMA,
+ DRM_IOCTL_MODE_GETENCODER,
+ DRM_IOCTL_MODE_ATTACHMODE,
+ DRM_IOCTL_MODE_DETACHMODE,
+ DRM_IOCTL_MODE_GETPROPERTY,
+ DRM_IOCTL_MODE_GETPROPBLOB,
+ DRM_IOCTL_MODE_OBJ_GETPROPERTIES,
+ DRM_IOCTL_MODE_CREATEPROPBLOB,
+ DRM_IOCTL_MODE_DESTROYPROPBLOB,
+ DRM_IOCTL_MODE_CREATE_LEASE,
+ DRM_IOCTL_MODE_LIST_LESSEES,
+ DRM_IOCTL_MODE_GET_LEASE,
+ DRM_IOCTL_MODE_REVOKE_LEASE,
+};
+
long amdgpu_drm_ioctl(struct file *filp,
unsigned int cmd, unsigned long arg)
{
struct drm_file *file_priv = filp->private_data;
struct drm_device *dev;
long ret;
+ bool wake = true;
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE(no_wake_ioctl_list); i++) {
+ if (cmd == no_wake_ioctl_list[i]) {
+ wake = false;
+ break;
+ }
+ }
dev = file_priv->minor->dev;
- ret = pm_runtime_get_sync(dev->dev);
- if (ret < 0)
- goto out;
+ if (wake) {
+ ret = pm_runtime_get_sync(dev->dev);
+ if (ret < 0)
+ goto out;
+ }
ret = drm_ioctl(filp, cmd, arg);
- pm_runtime_mark_last_busy(dev->dev);
+ if (wake)
+ pm_runtime_mark_last_busy(dev->dev);
out:
- pm_runtime_put_autosuspend(dev->dev);
+ if (wake)
+ pm_runtime_put_autosuspend(dev->dev);
return ret;
}
--
2.50.1
next prev parent reply other threads:[~2025-07-31 5:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 5:36 [PATCH RFC 0/6] amdgpu: Avoid powering on the dGPU on vkEnumeratePhysicalDevices() Philipp Zabel
2025-07-31 5:36 ` Philipp Zabel [this message]
2025-07-31 5:36 ` [PATCH RFC 2/6] drm/amdgpu: don't wake up the GPU when opening the device Philipp Zabel
2025-07-31 5:36 ` [PATCH RFC 3/6] drm/amdgpu: don't query xclk in AMDGPU_INFO_DEV_INFO Philipp Zabel
2025-07-31 5:36 ` [PATCH RFC 4/6] drm/amdgpu: don't wake up the GPU for some AMDGPU_INFO queries Philipp Zabel
2025-07-31 5:36 ` [PATCH RFC 5/6] drm/amdgpu: don't wake up the GPU for mmGB_ADDR_CONFIG register read Philipp Zabel
2025-07-31 19:38 ` Alex Deucher
[not found] ` <CA+gwMcc41Hh=or7NLMnG++miHj_dNLZ04iFYdf=U7_LLG1gSZw@mail.gmail.com>
2025-08-01 15:27 ` Alex Deucher
2025-07-31 5:36 ` [PATCH RFC 6/6] drm/amdgpu: don't wake up the GPU for syncobj feature detection Philipp Zabel
2025-08-06 8:58 ` [PATCH RFC 0/6] amdgpu: Avoid powering on the dGPU on vkEnumeratePhysicalDevices() Christian König
2025-08-06 10:15 ` Philipp Zabel
2025-08-06 13:17 ` Christian König
2025-08-20 7:42 ` Pierre-Eric Pelloux-Prayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250731-b4-dont-wake-next-v1-1-e51bdc347fa3@gmail.com \
--to=philipp.zabel@gmail.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®