mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 "Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
	 linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: [PATCH 0/2] regmap: Fix lockdep warnings for nested regmap-irqs
Date: Thu, 31 Jul 2025 21:38:17 +0100	[thread overview]
Message-ID: <20250731-regmap-irq-nesting-v1-0-98b4d1bf20f0@kernel.org> (raw)

Russell King reported that lockdep warns when it sees nested regmap-irq
interrupt controllers since it defaults to using a single lock class for
all mutexes allocated from a single place in the code.  We end up with
both the parent and child regmap-irq locked simultaneously.  The second
patch here uses an explicit lockdep key to disambiguate things for
regmap, the first adds missing mutex cleanup which I noticed while
writing that patch.

I don't have an affected system so this is written blind, I should
really write some KUnit tests for regmap-irq but didn't yet.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
Mark Brown (2):
      regmap: irq: Free the regmap-irq mutex
      regmap: irq: Avoid lockdep warnings with nested regmap-irq chips

 drivers/base/regmap/regmap-irq.c | 30 +++++++++++++++++++++---------
 1 file changed, 21 insertions(+), 9 deletions(-)
---
base-commit: 038d61fd642278bab63ee8ef722c50d10ab01e8f
change-id: 20250731-regmap-irq-nesting-40970c711fd2

Best regards,
--  
Mark Brown <broonie@kernel.org>


             reply	other threads:[~2025-07-31 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31 20:38 Mark Brown [this message]
2025-07-31 20:38 ` [PATCH 1/2] regmap: irq: Free the regmap-irq mutex Mark Brown
2025-08-01 12:27   ` Russell King (Oracle)
2025-08-01 12:29   ` Russell King (Oracle)
2025-07-31 20:38 ` [PATCH 2/2] regmap: irq: Avoid lockdep warnings with nested regmap-irq chips Mark Brown
2025-08-01 12:28   ` Russell King (Oracle)
2025-08-01 18:14 ` [PATCH 0/2] regmap: Fix lockdep warnings for nested regmap-irqs Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250731-regmap-irq-nesting-v1-0-98b4d1bf20f0@kernel.org \
    --to=broonie@kernel.org \
    --cc=dakr@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®