From: Paul Kocialkowski <paulk@sys-base.io>
To: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Cc: Jack Zhu <jack.zhu@starfivetech.com>,
Changhuang Liang <changhuang.liang@starfivetech.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Paul Kocialkowski <paulk@sys-base.io>
Subject: [PATCH] media: starfive: camss: Use common dma-contig dma addr helper
Date: Fri, 1 Aug 2025 10:21:49 +0200 [thread overview]
Message-ID: <20250801082149.591192-1-paulk@sys-base.io> (raw)
The vb2_plane_cookie helpers is not meant to be used directly by
drivers using the generic dma-contig allocator.
Use the common helper to retrieve the plane dma address instead.
Signed-off-by: Paul Kocialkowski <paulk@sys-base.io>
---
drivers/staging/media/starfive/camss/stf-video.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/media/starfive/camss/stf-video.c b/drivers/staging/media/starfive/camss/stf-video.c
index a0420eb6a0aa..b0b9b70b9641 100644
--- a/drivers/staging/media/starfive/camss/stf-video.c
+++ b/drivers/staging/media/starfive/camss/stf-video.c
@@ -167,10 +167,8 @@ static int video_buf_init(struct vb2_buffer *vb)
struct stfcamss_video *video = vb2_get_drv_priv(vb->vb2_queue);
struct stfcamss_buffer *buffer = to_stfcamss_buffer(vbuf);
const struct v4l2_pix_format *fmt = &video->active_fmt.fmt.pix;
- dma_addr_t *paddr;
- paddr = vb2_plane_cookie(vb, 0);
- buffer->addr[0] = *paddr;
+ buffer->addr[0] = vb2_dma_contig_plane_dma_addr(vb, 0);
if (fmt->pixelformat == V4L2_PIX_FMT_NV12)
buffer->addr[1] =
--
2.50.1
next reply other threads:[~2025-08-01 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 8:21 Paul Kocialkowski [this message]
2025-08-05 0:45 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250801082149.591192-1-paulk@sys-base.io \
--to=paulk@sys-base.io \
--cc=changhuang.liang@starfivetech.com \
--cc=hverkuil@xs4all.nl \
--cc=jack.zhu@starfivetech.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®