From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B446C21E0BA; Fri, 1 Aug 2025 13:34:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754055279; cv=none; b=CCBQ/GGJLqvXjuIuzWUmzi/s6XufvXp24MgB+FuQvPOY9iqDaGhNLOgirtEaecDbbTzBrfzxUygFie/zsyUnad87sNffGqXfIs07m1a1Pe1kHRNr5aINtQLiQpCa2ut66mprPSfNXmUnoOol/ycbBF36kDcUpmk/P6OIZcz4hy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754055279; c=relaxed/simple; bh=N/x7XAFTjXtfUPb0qJUtTXRvmOGAsMR5K5uMplm4A70=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TNhPJqpyDoCX0UtFL5Nf7XtVt5PuPLd+0W3STgKKFVZzj40vO/ns86EBpipej5DAQTwGJqfeH9HM8wegLjYxQJBkTrdIpca4TDFXlRRQpTm2XTTRoEKsRdLUYbIilndaE1QPPzCgynrWFPTPDqFOKeraviY4QkQs+Pxiy4Aw5FM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jsM27rDa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jsM27rDa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 134B7C4CEE7; Fri, 1 Aug 2025 13:34:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1754055276; bh=N/x7XAFTjXtfUPb0qJUtTXRvmOGAsMR5K5uMplm4A70=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jsM27rDaQLXAjtU5Vfms10gU7akFQ5pIehCS5bt+fKEKoZ1u7Vf5CiK0LOmE0Unf2 tHVHlkKsBG/MfTc0d2rJf8oZ+oHG4KniX21M2hI1Zn1yMKex+Q/Ih/Dur9xp3J6gHw Y2pU9mQmM1V4OH+VOk/nGr7iyIrj9MZYXJ1ntBCkIakICEtNbNMN5L13vy6Hd+nnN/ AFn/GASyQ6s4LOf2sbqdDz0avR1CBC6Mrk7plRMTJKJqSoI4QWT5QIF2F+zHGR89o6 v5A0waIArdK/1qoGCeDVXIGkL6deyN2XwGitCAhn7QT1OZIzgXMHonj4zjdWBNELSw eP8KrN5aC4sww== Date: Fri, 1 Aug 2025 08:34:35 -0500 From: Rob Herring To: Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Krzysztof Kozlowski , Conor Dooley , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Miquel Raynal Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH] dt-binding: thermal: Convert marvell,armada-ap806-thermal to DT schema Message-ID: <20250801133435.GA3024231-robh@kernel.org> References: <20250702230030.2892116-1-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250702230030.2892116-1-robh@kernel.org> On Wed, Jul 02, 2025 at 06:00:29PM -0500, Rob Herring (Arm) wrote: > Convert the Marvell Armada AP80x/CP110 thermal binding to schema. It is > a straight forward conversion. > > Signed-off-by: Rob Herring (Arm) > --- > .../arm/marvell/ap80x-system-controller.txt | 39 ---------------- > .../arm/marvell/cp110-system-controller.txt | 43 ------------------ > .../thermal/marvell,armada-ap806-thermal.yaml | 44 +++++++++++++++++++ > 3 files changed, 44 insertions(+), 82 deletions(-) > create mode 100644 Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml Ping! > > diff --git a/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt > index c83245065d44..72de11bd2ef0 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt > +++ b/Documentation/devicetree/bindings/arm/marvell/ap80x-system-controller.txt > @@ -115,45 +115,6 @@ ap_syscon: system-controller@6f4000 { > SYSTEM CONTROLLER 1 > =================== > > -Thermal: > --------- > - > -For common binding part and usage, refer to > -Documentation/devicetree/bindings/thermal/thermal*.yaml > - > -The thermal IP can probe the temperature all around the processor. It > -may feature several channels, each of them wired to one sensor. > - > -It is possible to setup an overheat interrupt by giving at least one > -critical point to any subnode of the thermal-zone node. > - > -Required properties: > -- compatible: must be one of: > - * marvell,armada-ap806-thermal > -- reg: register range associated with the thermal functions. > - > -Optional properties: > -- interrupts: overheat interrupt handle. Should point to line 18 of the > - SEI irqchip. See interrupt-controller/interrupts.txt > -- #thermal-sensor-cells: shall be <1> when thermal-zones subnodes refer > - to this IP and represents the channel ID. There is one sensor per > - channel. O refers to the thermal IP internal channel, while positive > - IDs refer to each CPU. > - > -Example: > -ap_syscon1: system-controller@6f8000 { > - compatible = "syscon", "simple-mfd"; > - reg = <0x6f8000 0x1000>; > - > - ap_thermal: thermal-sensor@80 { > - compatible = "marvell,armada-ap806-thermal"; > - reg = <0x80 0x10>; > - interrupt-parent = <&sei>; > - interrupts = <18>; > - #thermal-sensor-cells = <1>; > - }; > -}; > - > Cluster clocks: > --------------- > > diff --git a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt > index 9d5d70c98058..54ff9f218328 100644 > --- a/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt > +++ b/Documentation/devicetree/bindings/arm/marvell/cp110-system-controller.txt > @@ -189,46 +189,3 @@ CP110_LABEL(syscon0): system-controller@440000 { > }; > > }; > - > -SYSTEM CONTROLLER 1 > -=================== > - > -Thermal: > --------- > - > -The thermal IP can probe the temperature all around the processor. It > -may feature several channels, each of them wired to one sensor. > - > -It is possible to setup an overheat interrupt by giving at least one > -critical point to any subnode of the thermal-zone node. > - > -For common binding part and usage, refer to > -Documentation/devicetree/bindings/thermal/thermal*.yaml > - > -Required properties: > -- compatible: must be one of: > - * marvell,armada-cp110-thermal > -- reg: register range associated with the thermal functions. > - > -Optional properties: > -- interrupts-extended: overheat interrupt handle. Should point to > - a line of the ICU-SEI irqchip (116 is what is usually used by the > - firmware). The ICU-SEI will redirect towards interrupt line #37 of the > - AP SEI which is shared across all CPs. > - See interrupt-controller/interrupts.txt > -- #thermal-sensor-cells: shall be <1> when thermal-zones subnodes refer > - to this IP and represents the channel ID. There is one sensor per > - channel. O refers to the thermal IP internal channel. > - > -Example: > -CP110_LABEL(syscon1): system-controller@6f8000 { > - compatible = "syscon", "simple-mfd"; > - reg = <0x6f8000 0x1000>; > - > - CP110_LABEL(thermal): thermal-sensor@70 { > - compatible = "marvell,armada-cp110-thermal"; > - reg = <0x70 0x10>; > - interrupts-extended = <&CP110_LABEL(icu_sei) 116 IRQ_TYPE_LEVEL_HIGH>; > - #thermal-sensor-cells = <1>; > - }; > -}; > diff --git a/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml b/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml > new file mode 100644 > index 000000000000..fdbdf3c1273a > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/marvell,armada-ap806-thermal.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/marvell,armada-ap806-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Marvell Armada AP80x/CP110 thermal management > + > +maintainers: > + - Miquel Raynal > + > +properties: > + compatible: > + enum: > + - marvell,armada-ap806-thermal > + - marvell,armada-ap807-thermal > + - marvell,armada-cp110-thermal > + > + reg: > + maxItems: 1 > + > + interrupts: > + description: overheat interrupt > + maxItems: 1 > + > + '#thermal-sensor-cells': > + description: Cell represents the channel ID. There is one sensor per > + channel. O refers to the thermal IP internal channel. > + const: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + thermal-sensor@80 { > + compatible = "marvell,armada-ap806-thermal"; > + reg = <0x80 0x10>; > + interrupts = <18>; > + #thermal-sensor-cells = <1>; > + }; > -- > 2.47.2 >