From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Imene Jaziri <imenjazirii18@gmail.com>
Cc: linux-media@vger.kernel.org, hansg@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Log driver load in uvc_probe function
Date: Fri, 1 Aug 2025 18:04:30 +0300 [thread overview]
Message-ID: <20250801150430.GC4906@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20250801145326.28560-1-imenjazirii18@gmail.com>
Hi,
On Fri, Aug 01, 2025 at 03:53:26PM +0100, Imene Jaziri wrote:
> Add a pr_info() in the uvc_probe function to trace when the
> uvcvideo driver is loaded. This is for learning purposes.
What part of the learning instructions you are following instructed you
to submit this patch to kernel mailing lists ? We are regularly spammed
by similar patches, which indicates the instructions are not clear
enough.
> Signed-off-by: Imene Jaziri <imenjazirii18@gmail.com>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index da24a655ab68..4e5d1d636640 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2170,7 +2170,6 @@ static int uvc_probe(struct usb_interface *intf,
> (const struct uvc_device_info *)id->driver_info;
> int function;
> int ret;
> -
> /* Allocate memory for the device and initialize it. */
> dev = kzalloc(sizeof(*dev), GFP_KERNEL);
> if (dev == NULL)
> @@ -2188,7 +2187,7 @@ static int uvc_probe(struct usb_interface *intf,
> dev->info = info ? info : &uvc_quirk_none;
> dev->quirks = uvc_quirks_param == -1
> ? dev->info->quirks : uvc_quirks_param;
> -
> + pr_info("I changed uvcvideo driver in the Linux Kernel\n");
> if (id->idVendor && id->idProduct)
> uvc_dbg(dev, PROBE, "Probing known UVC device %s (%04x:%04x)\n",
> udev->devpath, id->idVendor, id->idProduct);
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2025-08-01 15:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 14:53 Imene Jaziri
2025-08-01 15:04 ` Laurent Pinchart [this message]
2025-08-07 7:53 ` Benjamin Mugnier
2025-08-07 8:14 ` Laurent Pinchart
2025-08-07 18:40 ` Shuah Khan
2025-08-07 19:05 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250801150430.GC4906@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hansg@kernel.org \
--cc=imenjazirii18@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®