From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 489571AC44D for ; Fri, 1 Aug 2025 17:00:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754067619; cv=none; b=YAxL0cloP+qgbr7OVMR40OAdZZx08CU4gicwOe+DOjWK/GUmahbgaHyXU4QysRJqvZfOBUBCH2a3iHMEowtujbDi8qMQ7XxLxM7IOfhanhg8B0+zy+g6wDrv7Z5bzenOIKC02GRn11XJZ94oVmpqypiiFrgWFgNMKIn+DsOBj8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754067619; c=relaxed/simple; bh=ixzhB2IWkCoD0F1aKbqXUptaL4fTvucgYZy4AJNb4ck=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J5bbDrbFvMtMgfiFGln1XkCJ13iQopWsmkDX7sHSQTdWoskTXMYoYq2efDWgZsrGiL7f9hKqNyprUGqjmCYgKLi9wQZTqFPVkixk53vULD4vm74QY0SB7V3O0xWNWbrgktSPZjo7zjHdV8uraLz60QxoCy3IHZWKFhYGFTBJmkA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=BdKQwNse; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="BdKQwNse" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7e2c920058fso339032585a.0 for ; Fri, 01 Aug 2025 10:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1754067616; x=1754672416; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QwE+9sTgjNRdMVVYO7khCffe4vKwvJxjH8fF2V6zz5I=; b=BdKQwNse6pRrj/tOebPDpz5/au+yyTJVkZhAEihoTdxL5JLbjUtin2tHbPSdTwKDZS k+nbnR1YyNnEWE8XAyHqo/lk5tgdlq97oe48JGWIFhhLeW/O/XOGnF2T7ItGvxs7mKpc Hm2g2aS06SNiMrrCVcq9jnvLV0FryY1hWIcL9ksE516v2sOnS7IirX5sA9n7oWY4PFMV 97zLmaElZJ+G4Its4Z6Lol3SZJAjPJ3WM5DHoLxE+N4HD9/9nMTTqhml9kpWsJV5C/u1 GOQy3m1WTTy+cUzJqdHSZO7bNxEXRa/olGZufNJvzFSbbTHt9DWg9/K4vUiBF5NUxitL J71g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754067616; x=1754672416; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QwE+9sTgjNRdMVVYO7khCffe4vKwvJxjH8fF2V6zz5I=; b=Sy1BZTWnKhvWey0iDdgv3C6O53sqoniyqhr0fRTaC+pfhqTpvjK4X5F+dYk1Jx4rGk N39sUJnLXnEw7USs7DenPlbHjMbpoMz2cxU9poe8sdhT71eGteUmKE5XjbG+NILGFVvZ kBDjiJvv1EDTh7FcWISSREGjD2orb+EcvhssqjDNX8EpBe+Uao9G5hGMQXuL8MgDu8DA 3lyd5BHuv94X5c6kyFQl3JQrT1m6rTU/fHgrsM5yo9IdaXjqf82hj1n8yYM717uKPccE X2sXI1m6jhuR5qFzRHmcQ/I6mPZ1SYB0vO/VnYGA7k0KZgzdjWuAowWIwmjwHUWKc+0K uvUg== X-Forwarded-Encrypted: i=1; AJvYcCWEyo2fwsRNECOIMQXfc4mBWnEtbujkG+CFPw1Ed8HvqJoYfW8ShiefCfrNR/31c4I4xZ1w3iF8XV+8EyI=@vger.kernel.org X-Gm-Message-State: AOJu0YzWzGITCatkaViOHIVtASX00Y2xvn71Ex5qvL4u+mds3DufpXb4 3DQKD4bf/Aasa2Hwvwficb2Kam0+LFmw5Xl+YDkbUe7OoRJtmRBTTQg2v0fc+c4GndM= X-Gm-Gg: ASbGnct/mtk1ILw6aasi9DNBgrgcEgXuGUPISO/7w/+72+3zgjcTUGrNfbAv4qDfnfy BGk3afB5UVTsQEWiR4BnsKdCyUEmXrAyHKjtYgY3MzuNuAjGLdC8KxrV/1MdHAMDRF7PmTl2ND3 hCud5j9D1Um8Ru5itW9SKDFVpVdoNTaROZBXMYhNf96WO1wphs3r2XwKpOnUxuDbQB9K4zdweax 4N1n9Q1admSSaaS0RIoLlXc582mmSynpnRtB5qXOQ1MlFXyxSldh+UGob4NobO5CC+bk7UfCRTK zprWbaDQwM2lpbDhXyPPoXtAc82Bu98a7pywpPM+ivtaeHI/u6VT4vhKbkpZuUpjF/B/Fm8HtxZ odW2glge8PRHlUc1doVTThbPsidd2VO4nobdLs7w4snaQztWWNLYy2DIGPdahNFdymws56NXfqh UKyT8= X-Google-Smtp-Source: AGHT+IGeo72sFurahqpXhqOszMWIFx1nBofLsBki44tDG5x4fiYUv0PBxN8jfJdDWgnL5yoXO3nTZg== X-Received: by 2002:ae9:f10d:0:b0:7e6:5f1c:4d78 with SMTP id af79cd13be357-7e696650ea8mr57651285a.33.1754067616031; Fri, 01 Aug 2025 10:00:16 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-120-4.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.120.4]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e67f75c053sm235155785a.81.2025.08.01.10.00.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Aug 2025 10:00:15 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1uht78-000000013Jb-2qVs; Fri, 01 Aug 2025 14:00:14 -0300 Date: Fri, 1 Aug 2025 14:00:14 -0300 From: Jason Gunthorpe To: Simon Horman Cc: Abhijit Gangurde , shannon.nelson@amd.com, brett.creeley@amd.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net, leon@kernel.org, andrew+netdev@lunn.ch, allen.hubbe@amd.com, nikhil.agarwal@amd.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 03/14] net: ionic: Export the APIs from net driver to support device commands Message-ID: <20250801170014.GG26511@ziepe.ca> References: <20250723173149.2568776-1-abhijit.gangurde@amd.com> <20250723173149.2568776-4-abhijit.gangurde@amd.com> <20250725164106.GI1367887@horms.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250725164106.GI1367887@horms.kernel.org> On Fri, Jul 25, 2025 at 05:41:06PM +0100, Simon Horman wrote: > On Wed, Jul 23, 2025 at 11:01:38PM +0530, Abhijit Gangurde wrote: > > RDMA driver needs to establish admin queues to support admin operations. > > Export the APIs to send device commands for the RDMA driver. > > > > Reviewed-by: Shannon Nelson > > Signed-off-by: Abhijit Gangurde > > Hi Abhijit, > > Perhaps I misunderstand things, or otherwise am on the wrong track here. > But this seems to open the possibility of users of ionic_adminq_post_wait(), > outside the Ethernet driver, executing a wide range or admin commands. > It seems to me that it would be nice to narrow that surface. The kernel is monolithic, it is not normal to spend performance aggressively policing APIs. mlx5 and other drivers already have interfaces almost exactly like this. Jason