From: Eric Biggers <ebiggers@kernel.org>
To: Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
linux-integrity@vger.kernel.org
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Biggers <ebiggers@kernel.org>
Subject: [PATCH v2 0/2] tpm: Clean up HMAC validation and computation
Date: Fri, 1 Aug 2025 14:24:20 -0700 [thread overview]
Message-ID: <20250801212422.9590-1-ebiggers@kernel.org> (raw)
Patch 1 updates the tpm driver to compare HMAC values in constant time.
Patch 2 simplifies the HMAC computation in the tpm driver by using the
library API instead of an open-coded HMAC implementation. Note that
this depends on the HMAC library API that was merged for v6.17-rc1.
Changed in v2:
- Updated commit message of patch 1 to no longer characterize it as a
fix. Explained why the side channel seems to have been benign.
Eric Biggers (2):
tpm: Compare HMAC values in constant time
tpm: Use HMAC-SHA256 library instead of open-coded HMAC
drivers/char/tpm/Kconfig | 1 +
drivers/char/tpm/tpm2-sessions.c | 104 +++++++++----------------------
2 files changed, 31 insertions(+), 74 deletions(-)
base-commit: d6084bb815c453de27af8071a23163a711586a6c
--
2.50.1
next reply other threads:[~2025-08-01 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 21:24 Eric Biggers [this message]
2025-08-01 21:24 ` [PATCH v2 1/2] tpm: Compare HMAC values in constant time Eric Biggers
2025-08-05 13:50 ` Jarkko Sakkinen
2025-08-05 16:07 ` Eric Biggers
2025-08-09 10:36 ` Jarkko Sakkinen
2025-08-09 17:38 ` Eric Biggers
2025-09-04 2:38 ` Eric Biggers
2025-09-10 17:10 ` Jarkko Sakkinen
2025-08-01 21:24 ` [PATCH v2 2/2] tpm: Use HMAC-SHA256 library instead of open-coded HMAC Eric Biggers
2025-08-05 13:51 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250801212422.9590-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®