From: Horatiu Vultur <horatiu.vultur@microchip.com>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <richardcochran@gmail.com>,
<viro@zeniv.linux.org.uk>, <quentin.schulz@bootlin.com>,
<atenart@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] phy: mscc: Fix timestamping for vsc8584
Date: Mon, 4 Aug 2025 09:39:40 +0200 [thread overview]
Message-ID: <20250804073940.4wgpstdm53atrbbq@DEN-DL-M31836.microchip.com> (raw)
In-Reply-To: <20250801112648.4hm2h6n3b64guagi@skbuf>
The 08/01/2025 14:26, Vladimir Oltean wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hi Horatiu,
Hi Vladimir,
>
> On Thu, Jul 31, 2025 at 02:19:20PM +0200, Horatiu Vultur wrote:
> > diff --git a/drivers/net/phy/mscc/mscc.h b/drivers/net/phy/mscc/mscc.h
> > index 6a3d8a754eb8d..7281eea2395bd 100644
> > --- a/drivers/net/phy/mscc/mscc.h
> > +++ b/drivers/net/phy/mscc/mscc.h
> > @@ -362,6 +362,13 @@ struct vsc85xx_hw_stat {
> > u16 mask;
> > };
> >
> > +struct vsc8531_skb {
> > + struct list_head list;
> > +
> > + struct sk_buff *skb;
> > + u32 ns;
> > +};
>
> Can you map a typed structure over the skb->cb area to avoid allocating
> this encapsulating structure over the sk_buff?
I think it is a great idea. I can map struct vsc8531_skb directly on
skb->cb and then drop the allocation.
--
/Horatiu
next prev parent reply other threads:[~2025-08-04 7:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 12:19 Horatiu Vultur
2025-08-01 11:26 ` Vladimir Oltean
2025-08-04 7:39 ` Horatiu Vultur [this message]
2025-08-04 10:24 ` Vladimir Oltean
2025-08-04 10:30 ` Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250804073940.4wgpstdm53atrbbq@DEN-DL-M31836.microchip.com \
--to=horatiu.vultur@microchip.com \
--cc=andrew@lunn.ch \
--cc=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=quentin.schulz@bootlin.com \
--cc=richardcochran@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®