Re: [PATCH] pid: Add a judgment for ns null in pid_nr_ns

[Oleg Nesterov <oleg@redhat.com>]

On 08/04, Christian Brauner wrote:
>
> On Mon, Aug 04, 2025 at 01:49:01PM +0200, Oleg Nesterov wrote:
> >
> > You need something like
> >
> > 	info->pid = info->ppid = 0;
> >
> > 	rcu_read_lock();
> > 	if (pid_alive(tsk)) {
> > 		info->pid = task_pid_vnr(tsk);
> > 		info->ppid = task_tgid_vnr(tsk->real_parent);
> > 	}
> > 	rcu_read_unlock();
>
> I distinctly remember having seen a similar patch about 5 years ago that
> did the exact same fix for some out-of-tree abuse:
> 20201201024811.GA72235@ip-172-31-62-0.us-west-2.compute.internal
>
> Where in the kernel is that code supposed to live? Is this again an
> out-of-tree module?

I don't know.

But. I need to re-check, but I just realized that pid_alive() can't
really help, tsk->thread_pid is not stable even if tsk == current.

This means that, say, task_ppid_nr_ns() is buggy.

I'll return to this tomorrow.

Oleg.