From: Colin Ian King <colin.i.king@gmail.com>
To: Frank <Frank.Sae@motor-comm.com>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] net: phy: motorcomm: make const array mac_addr_reg static
Date: Thu, 7 Aug 2025 14:15:04 +0100 [thread overview]
Message-ID: <20250807131504.463704-1-colin.i.king@gmail.com> (raw)
Don't populate the const read-only arrays mac_addr_reg on the stack at
run time, instead make them static, this reduces the object code size.
Size before:
text data bss dec hex filename
65066 11352 0 76418 12a82 drivers/net/phy/motorcomm.o
Size after:
text data bss dec hex filename
64761 11512 0 76273 129f1 drivers/net/phy/motorcomm.o
Reducton of 145 bytes (gcc 14.2.0 x86-64)
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/phy/motorcomm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c
index 0e91f5d1a4fd..aeae7ec897c6 100644
--- a/drivers/net/phy/motorcomm.c
+++ b/drivers/net/phy/motorcomm.c
@@ -536,7 +536,7 @@ static void ytphy_get_wol(struct phy_device *phydev,
static int ytphy_set_wol(struct phy_device *phydev, struct ethtool_wolinfo *wol)
{
struct net_device *p_attached_dev;
- const u16 mac_addr_reg[] = {
+ static const u16 mac_addr_reg[] = {
YTPHY_WOL_MACADDR2_REG,
YTPHY_WOL_MACADDR1_REG,
YTPHY_WOL_MACADDR0_REG,
@@ -608,7 +608,7 @@ static int ytphy_set_wol(struct phy_device *phydev, struct ethtool_wolinfo *wol)
static int yt8531_set_wol(struct phy_device *phydev,
struct ethtool_wolinfo *wol)
{
- const u16 mac_addr_reg[] = {
+ static const u16 mac_addr_reg[] = {
YTPHY_WOL_MACADDR2_REG,
YTPHY_WOL_MACADDR1_REG,
YTPHY_WOL_MACADDR0_REG,
--
2.50.1
next reply other threads:[~2025-08-07 13:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 13:15 Colin Ian King [this message]
2025-08-08 18:48 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807131504.463704-1-colin.i.king@gmail.com \
--to=colin.i.king@gmail.com \
--cc=Frank.Sae@motor-comm.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®