mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Nicolas Schier <nicolas.schier@linux.dev>
Cc: Haoran lee <470658536@qq.com>,
	masahiroy@kernel.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/mod/modpost: For CentOS 7/old binutils compatibility
Date: Thu, 7 Aug 2025 09:22:38 -0700	[thread overview]
Message-ID: <20250807162238.GB2145434@ax162> (raw)
In-Reply-To: <20250807-elastic-transparent-kingfisher-8f7ada@l-nschier-aarch64>

On Thu, Aug 07, 2025 at 12:51:59PM +0200, Nicolas Schier wrote:
> On Tue, Jul 29, 2025 at 12:19:46AM +0800, Haoran lee wrote:
> > 
> > Signed-off-by: Haoran Lee <470658536@qq.com>
> > ---
> 
> Please note that empty commit descriptions will not be accepted.

Agreed, a clear description of the issue (including an error message)
and logic of the fix is needed.

> >  scripts/mod/modpost.c | 26 ++++++++++++++++++++++++++
> >  1 file changed, 26 insertions(+)
> > 
> > diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> > index 5ca7c268294e..216647e2f301 100644
> > --- a/scripts/mod/modpost.c
> > +++ b/scripts/mod/modpost.c
> > @@ -30,6 +30,32 @@
> >  
> >  #define MODULE_NS_PREFIX "module:"
> >  
> > +/* CentOS 7 / old binutils compatibility */
> 
> Since v6.16-rc1 the minimum binutils version has been lifted to 
> binutils-2.30 [1].
> 
> [1]: https://git.kernel.org/torvalds/c/118c40b7b50340bf7ff7e0adee8e3
> 
> Which binutils version do you have at CentOS 7 ?

These values come from glibc's elf.h if I understand correctly, so I
think this is more about compatibility with versions of glibc that do
not have these relocations defined, rather than binutils.

It appears these were all added in glibc 2.18 over ten years ago [1],
whereas CentOS 7 appears to use glibc 2.17. There is some prior art to
adding elf.h constants to modpost.c when they are not defined by elf.h
but I am not sure if it is worth it in this case, as CentOS 7 has been
EOL for over a year at this point (and I suspect the binutils / GCC
version is already prohibitive for working on mainline).

If we do want to add these relocation defines, I think they should be
added in order of their numerical value. I do not have a strong opinion
either way.

[1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=08cbd996d33114ca50644d060fbe3a08260430fb

Cheers,
Nathan

  reply	other threads:[~2025-08-07 16:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28 16:19 Haoran lee
2025-08-07 10:51 ` Nicolas Schier
2025-08-07 16:22   ` Nathan Chancellor [this message]
2025-08-07 18:55     ` Nicolas Schier
2025-08-08  3:06   ` Haoran lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250807162238.GB2145434@ax162 \
    --to=nathan@kernel.org \
    --cc=470658536@qq.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nicolas.schier@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®