From: Corey Minyard <corey@minyard.net>
To: Frederick Lawler <fred@cloudflare.com>
Cc: openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, kernel-team@cloudflare.com,
Corey Minyard <corey@minyard.net>
Subject: [PATCH 2/4] ipmi: Disable sysfs access and requests in maintenance mode
Date: Thu, 7 Aug 2025 18:02:33 -0500 [thread overview]
Message-ID: <20250807230648.1112569-3-corey@minyard.net> (raw)
In-Reply-To: <20250807230648.1112569-1-corey@minyard.net>
If the driver goes into any maintenance mode, disable sysfs access until
it is done.
If the driver goes into reset maintenance mode, disable all messages
until it is done.
Signed-off-by: Corey Minyard <corey@minyard.net>
---
drivers/char/ipmi/ipmi_msghandler.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index f124c0b33db8..72f5f4a0c056 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -2338,6 +2338,11 @@ static int i_ipmi_request(struct ipmi_user *user,
if (!run_to_completion)
mutex_lock(&intf->users_mutex);
+ if (intf->maintenance_mode_state == IPMI_MAINTENANCE_MODE_STATE_RESET) {
+ /* No messages while the BMC is in reset. */
+ rv = -EBUSY;
+ goto out_err;
+ }
if (intf->in_shutdown) {
rv = -ENODEV;
goto out_err;
@@ -2639,6 +2644,12 @@ static int __bmc_get_device_id(struct ipmi_smi *intf, struct bmc_device *bmc,
(bmc->dyn_id_set && time_is_after_jiffies(bmc->dyn_id_expiry)))
goto out_noprocessing;
+ /* Don't allow sysfs access when in maintenance mode. */
+ if (intf->maintenance_mode_state) {
+ rv = -EBUSY;
+ goto out_noprocessing;
+ }
+
prev_guid_set = bmc->dyn_guid_set;
__get_guid(intf);
--
2.43.0
next prev parent reply other threads:[~2025-08-07 23:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 23:02 [RFC] Patches to disable messages during BMC reset Corey Minyard
2025-08-07 23:02 ` [PATCH 1/4] ipmi: Differentiate between reset and firmware update in maintenance Corey Minyard
2025-08-07 23:02 ` Corey Minyard [this message]
2025-08-08 20:37 ` [PATCH 2/4] ipmi: Disable sysfs access and requests in maintenance mode Frederick Lawler
2025-08-08 22:28 ` Corey Minyard
2025-08-07 23:02 ` [PATCH 3/4] ipmi: Add a maintenance mode sysfs file Corey Minyard
2025-08-07 23:02 ` [PATCH 4/4] ipmi: Set a timer for maintenance mode Corey Minyard
2025-08-15 21:23 ` [RFC] Patches to disable messages during BMC reset Frederick Lawler
2025-08-16 1:56 ` Corey Minyard
2025-08-18 15:14 ` Frederick Lawler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807230648.1112569-3-corey@minyard.net \
--to=corey@minyard.net \
--cc=fred@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®